@@ -345,27 +345,25 @@ void llvm::filterDeadComdatFunctions(
std::string llvm::getUniqueModuleId(Module *M) {
MD5 Md5;
- bool ExportsSymbols = false;
- auto AddGlobal = [&](GlobalValue &GV) {
-if (GV.isDeclaration() || GV.getName().starts_with("llvm.") ||
-!GV.h
@@ -345,27 +345,25 @@ void llvm::filterDeadComdatFunctions(
std::string llvm::getUniqueModuleId(Module *M) {
MD5 Md5;
- bool ExportsSymbols = false;
- auto AddGlobal = [&](GlobalValue &GV) {
-if (GV.isDeclaration() || GV.getName().starts_with("llvm.") ||
-!GV.h
vitalybuka wrote:
LGTM
https://github.com/llvm/llvm-project/pull/135728
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -345,27 +345,25 @@ void llvm::filterDeadComdatFunctions(
std::string llvm::getUniqueModuleId(Module *M) {
MD5 Md5;
- bool ExportsSymbols = false;
- auto AddGlobal = [&](GlobalValue &GV) {
-if (GV.isDeclaration() || GV.getName().starts_with("llvm.") ||
-!GV.h
pcc wrote:
https://github.com/llvm/llvm-project/pull/135832
https://github.com/llvm/llvm-project/pull/135728
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc wrote:
> Is the "name" in this context the whole path? Or just the filename? I know
> many projects have files with the same name in different folders (including
> LLVM itsef).
It is the whole path. Let me clarify this in the documentation.
https://github.com/llvm/llvm-project/pull/135728
https://github.com/efriedma-quic commented:
Is the "name" in this context the whole path? Or just the filename? I know
many projects have files with the same name in different folders (including
LLVM itsef).
https://github.com/llvm/llvm-project/pull/135728
___
https://github.com/pcc closed https://github.com/llvm/llvm-project/pull/135728
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/teresajohnson approved this pull request.
https://github.com/llvm/llvm-project/pull/135728
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
teresajohnson wrote:
> > I was mostly thinking that detecting and erroring at LTO time would result
> > in a clearer error (like at the start of LTO::addModule, where it is
> > looking for partially split LTO units, which we do by adding the module
> > flag to the index flags).
>
> I don't th
https://github.com/pcc updated https://github.com/llvm/llvm-project/pull/135728
>From 4ddc4d6fcd938b66cce586c18a9e165c6d065121 Mon Sep 17 00:00:00 2001
From: Peter Collingbourne
Date: Mon, 14 Apr 2025 19:04:00 -0700
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?
pcc wrote:
> Could that be addressed by only allowing this flag under LTO?
`-fsanitize=address -flto=thin` would have the same issue (if there is indeed
an issue, which I think there probably isn't).
> Probably at least add a note to the new documentation for the option that it
> will result
teresajohnson wrote:
> > I assume this will give a duplicate symbol linker error if used
> > inappropriately? Any chance of more subtle bugs?
>
> As far as LTO is concerned I think it can only result in a duplicate symbol
> error as the resulting symbols will have external strong linkage. Ther
13 matches
Mail list logo
