SLTozer wrote:
> Thanks for clarifying the pre-script fixes. With that resolved, this looks
> good to me.
TYVM for the LGTM! I'll leave the review up for a bit in case anyone has
anything further to add.
https://github.com/llvm/llvm-project/pull/91724
_
https://github.com/jryans approved this pull request.
Thanks for clarifying the pre-script fixes. With that resolved, this looks good
to me.
https://github.com/llvm/llvm-project/pull/91724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/91724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/SLTozer edited
https://github.com/llvm/llvm-project/pull/91724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SLTozer wrote:
> There's one part I did not fully understand. How did you identify the
> "pre-script fixups"? What's the importance of those changes? I did not seen
> any mention of that in your PR description.
Good question, I'll add my answer to the main description: The pre-script
fixups w
https://github.com/jryans commented:
Overall, your process looks good to me! Thanks for working on this and
including such a detailed description. This will surely aid downstream
maintainers. 😄
There's one part I did not fully understand. How did you identify the
"pre-script fixups"? What's
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
Author: Stephen Tozer (SLTozer)
Changes
This patch makes the final major change of the RemoveDIs project, changing the
default IR output from debug intrinsics to debug records.
This is expected to break a large number of tests: every single o