[clang] [llvm] [RemoveDIs] Print IR with debug records by default (PR #91724)

2024-05-13 Thread Stephen Tozer via cfe-commits
SLTozer wrote: > Thanks for clarifying the pre-script fixes. With that resolved, this looks > good to me. TYVM for the LGTM! I'll leave the review up for a bit in case anyone has anything further to add. https://github.com/llvm/llvm-project/pull/91724 _

[clang] [llvm] [RemoveDIs] Print IR with debug records by default (PR #91724)

2024-05-13 Thread J. Ryan Stinnett via cfe-commits
https://github.com/jryans approved this pull request. Thanks for clarifying the pre-script fixes. With that resolved, this looks good to me. https://github.com/llvm/llvm-project/pull/91724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [llvm] [RemoveDIs] Print IR with debug records by default (PR #91724)

2024-05-13 Thread Stephen Tozer via cfe-commits
https://github.com/SLTozer edited https://github.com/llvm/llvm-project/pull/91724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RemoveDIs] Print IR with debug records by default (PR #91724)

2024-05-13 Thread Stephen Tozer via cfe-commits
https://github.com/SLTozer edited https://github.com/llvm/llvm-project/pull/91724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RemoveDIs] Print IR with debug records by default (PR #91724)

2024-05-13 Thread Stephen Tozer via cfe-commits
SLTozer wrote: > There's one part I did not fully understand. How did you identify the > "pre-script fixups"? What's the importance of those changes? I did not seen > any mention of that in your PR description. Good question, I'll add my answer to the main description: The pre-script fixups w

[clang] [llvm] [RemoveDIs] Print IR with debug records by default (PR #91724)

2024-05-13 Thread J. Ryan Stinnett via cfe-commits
https://github.com/jryans commented: Overall, your process looks good to me! Thanks for working on this and including such a detailed description. This will surely aid downstream maintainers. 😄 There's one part I did not fully understand. How did you identify the "pre-script fixups"? What's

[clang] [llvm] [RemoveDIs] Print IR with debug records by default (PR #91724)

2024-05-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Stephen Tozer (SLTozer) Changes This patch makes the final major change of the RemoveDIs project, changing the default IR output from debug intrinsics to debug records. This is expected to break a large number of tests: every single o