efriedma-quic wrote:
Just under "clang" is fine.
https://github.com/llvm/llvm-project/pull/110188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
augusto2112 wrote:
And would that be an RFC under "clang"? Or is there a different section on
Discourse for feature proposals?
https://github.com/llvm/llvm-project/pull/110188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
efriedma-quic wrote:
For a new feature with no existing implementation/language specification, I
want to see community input from people who want to use it, and understand the
potential impact on other projects (in this context, debuggers). There isn't
any formal requirement that happens on D
augusto2112 wrote:
> As a new feature, this needs a proposal on Discourse.
@efriedma-quic as an RFC under clang? I wasn't aware this was a rule, is this a
recent change?
https://github.com/llvm/llvm-project/pull/110188
___
cfe-commits mailing list
cf
efriedma-quic wrote:
As a new feature, this needs a proposal on Discourse.
https://github.com/llvm/llvm-project/pull/110188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 commented:
CGDebugInfo related changes LGTM, I'll let the others comment on the rest
https://github.com/llvm/llvm-project/pull/110188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/110188
>From 807fc9a690555930ef0c047f0c4253c6204376a9 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 30 Mar 2023 14:01:36 -0700
Subject: [PATCH] [clang] Add "debug_transparent" attribute
The `debug_tran
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/110188
>From a28f8e716a7efe356e0088c00257edfc15132cb7 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 30 Mar 2023 14:01:36 -0700
Subject: [PATCH] [clang] Add "debug_transparent" attribute
The `debug_tran
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/110188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4566,6 +4583,7 @@ void CGDebugInfo::EmitFunctionDecl(GlobalDecl GD,
SourceLocation Loc,
llvm::DINodeArray Annotations = CollectBTFDeclTagAnnotations(D);
llvm::DISubroutineType *STy = getOrCreateFunctionType(D, FnType, Unit);
+
Michael137 wrote:
stray
https://github.com/Michael137 commented:
Can we add tests that we do the right thing for
constructors/destructors/inlined functions?
https://github.com/llvm/llvm-project/pull/110188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
@@ -109,6 +110,20 @@ static bool IsArtificial(VarDecl const *VD) {
cast(VD->getDeclContext())->isImplicit());
}
+static bool usesDebugTransparent(const Decl *D, const CodeGenModule &CGM) {
+ if (!D)
+return false;
+
+ if (auto *attr = D->get
augusto2112 wrote:
I opened this PR since I messed up
https://github.com/llvm/llvm-project/pull/109490
https://github.com/llvm/llvm-project/pull/110188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Augusto Noronha (augusto2112)
Changes
The `debug_transparent` attribute is intended as a hint for debuggers that this
function itself is not interesting, but it calls a function that might be. So,
when stepping in arrives at a fu
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 139688a699f6db784bd559b147334f1d51314f9c
09940c37f0b9075b4a2c06e39932f1f772a2a13f --e
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/110188
The `debug_transparent` attribute is intended as a hint for debuggers that this
function itself is not interesting, but it calls a function that might be. So,
when stepping in arrives at a function with th
16 matches
Mail list logo