hnrklssn wrote:
> I think the integration into lit is okay. The diff updater seems neat, but I
> think it could be taken into a separate change, see also the inline comment.
> In general, I think this PR really does three separate things, that ought to
> be in separate changes:
>
> * Add
@@ -0,0 +1,10 @@
+// RUN: %clang_cc1 -verify %s
+// RUN: diff %s %s.expected
hnrklssn wrote:
The files in the `Inputs` directory are not discovered by lit, so this doesn't
actually run the RUN lines. Instead a copy is made, and a new lit instance is
launched to
@@ -0,0 +1,10 @@
+// RUN: %clang_cc1 -verify %s
+// RUN: diff %s %s.expected
nhaehnle wrote:
The way I understand it, the update-verify-tests plugin in lit will overwrite
this source file, which may end up overwriting this RUN line if there is a bug.
Basically,
https://github.com/nhaehnle commented:
I think the integration into lit is okay. The diff updater seems neat, but I
think it could be taken into a separate change, see also the inline comment. In
general, I think this PR really does three separate things, that ought to be in
separate changes:
https://github.com/nhaehnle edited
https://github.com/llvm/llvm-project/pull/97369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hnrklssn wrote:
Added tests and updated the script. Instead of only being a free-standing
script it's now (along with the UTC scripts) integrated into llvm-lit to
automatically detect which script can update a failing test, using the new flag
`--update-tests`.
https://github.com/llvm/llvm-pro
https://github.com/hnrklssn edited
https://github.com/llvm/llvm-project/pull/97369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
