https://github.com/hnrklssn closed
https://github.com/llvm/llvm-project/pull/108425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic approved this pull request.
LGTM. I gave this a try and it seems to work well!
https://github.com/llvm/llvm-project/pull/108425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
hnrklssn wrote:
> Thank you. This pretty much LGTM, but it just occurred to me that there's a
> docs/CommandGuide/lit.rst which should be updated to document the new option.
Done
> As update-verify-tests was reverted, can you rebase this to just the
> update_test_checks support? On the LLVM s
https://github.com/hnrklssn updated
https://github.com/llvm/llvm-project/pull/108425
>From 6cdb6bec945725d69d1073deeb53b7485c7e40cd Mon Sep 17 00:00:00 2001
From: "Henrik G. Olsson"
Date: Wed, 28 Aug 2024 23:30:49 -0700
Subject: [PATCH 1/3] [Utils] Add --update-tests to lit
This adds a flag to
https://github.com/hnrklssn updated
https://github.com/llvm/llvm-project/pull/108425
>From 6cdb6bec945725d69d1073deeb53b7485c7e40cd Mon Sep 17 00:00:00 2001
From: "Henrik G. Olsson"
Date: Wed, 28 Aug 2024 23:30:49 -0700
Subject: [PATCH 1/2] [Utils] Add --update-tests to lit
This adds a flag to
nikic wrote:
As update-verify-tests was reverted, can you rebase this to just the
update_test_checks support? On the LLVM side, we definitely want to have this
feature.
https://github.com/llvm/llvm-project/pull/108425
___
cfe-commits mailing list
cfe
erichkeane wrote:
I mentioned on a separate commit here, but as a reviewer/code-owner, I very
much dislike the existence of tooling like this. I believe it to be actively
harmful to the project.
https://github.com/llvm/llvm-project/pull/108425
___
cf
https://github.com/nhaehnle commented:
Thank you. This pretty much LGTM, but it just occurred to me that there's a
docs/CommandGuide/lit.rst which should be updated to document the new option.
https://github.com/llvm/llvm-project/pull/108425
___
cfe-c
https://github.com/hnrklssn updated
https://github.com/llvm/llvm-project/pull/108425
>From 451a178dbb461e6b3dd264be6ede0aa26283dbbe Mon Sep 17 00:00:00 2001
From: "Henrik G. Olsson"
Date: Wed, 28 Aug 2024 23:30:49 -0700
Subject: [PATCH 1/5] [Utils] Add --update-tests to lit
This adds a flag to
https://github.com/hnrklssn updated
https://github.com/llvm/llvm-project/pull/108425
>From 451a178dbb461e6b3dd264be6ede0aa26283dbbe Mon Sep 17 00:00:00 2001
From: "Henrik G. Olsson"
Date: Wed, 28 Aug 2024 23:30:49 -0700
Subject: [PATCH 1/5] [Utils] Add --update-tests to lit
This adds a flag to
https://github.com/hnrklssn updated
https://github.com/llvm/llvm-project/pull/108425
>From 451a178dbb461e6b3dd264be6ede0aa26283dbbe Mon Sep 17 00:00:00 2001
From: "Henrik G. Olsson"
Date: Wed, 28 Aug 2024 23:30:49 -0700
Subject: [PATCH 1/4] [Utils] Add --update-tests to lit
This adds a flag to
@@ -2,3 +2,15 @@ config.substitutions = list(config.substitutions)
config.substitutions.insert(
0, (r"%clang\b", """*** Do not use the driver in Sema tests. ***""")
)
+
+if lit_config.update_tests:
+import sys
+import os
+
+curdir = os.path.dirname(os.path.realp
https://github.com/hnrklssn updated
https://github.com/llvm/llvm-project/pull/108425
>From 451a178dbb461e6b3dd264be6ede0aa26283dbbe Mon Sep 17 00:00:00 2001
From: "Henrik G. Olsson"
Date: Wed, 28 Aug 2024 23:30:49 -0700
Subject: [PATCH 1/3] [Utils] Add --update-tests to lit
This adds a flag to
https://github.com/nhaehnle edited
https://github.com/llvm/llvm-project/pull/108425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nhaehnle commented:
Thanks for splitting this up. It does look mostly good to me, but I do have two
comments.
https://github.com/llvm/llvm-project/pull/108425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
@@ -1,3 +1,5 @@
+// RUN: %clang_cc1 -verify %s
+// RUN: diff %s %s.expected
nhaehnle wrote:
I still think those new invocations of `diff` should be in `lit-plugin.test`.
Those `diff` lines attempt to check that this file (or rather its temporarily
copied versio
@@ -2,3 +2,15 @@ config.substitutions = list(config.substitutions)
config.substitutions.insert(
0, (r"%clang\b", """*** Do not use the driver in Sema tests. ***""")
)
+
+if lit_config.update_tests:
+import sys
+import os
+
+curdir = os.path.dirname(os.path.realp
https://github.com/hnrklssn updated
https://github.com/llvm/llvm-project/pull/108425
>From 451a178dbb461e6b3dd264be6ede0aa26283dbbe Mon Sep 17 00:00:00 2001
From: "Henrik G. Olsson"
Date: Wed, 28 Aug 2024 23:30:49 -0700
Subject: [PATCH 1/2] [Utils] Add --update-tests to lit
This adds a flag to
https://github.com/hnrklssn updated
https://github.com/llvm/llvm-project/pull/108425
>From 451a178dbb461e6b3dd264be6ede0aa26283dbbe Mon Sep 17 00:00:00 2001
From: "Henrik G. Olsson"
Date: Wed, 28 Aug 2024 23:30:49 -0700
Subject: [PATCH 1/2] [Utils] Add --update-tests to lit
This adds a flag to
https://github.com/hnrklssn updated
https://github.com/llvm/llvm-project/pull/108425
>From 11c5fe752a880dfa220abdf46ad9ba1a8be66b37 Mon Sep 17 00:00:00 2001
From: "Henrik G. Olsson"
Date: Wed, 28 Aug 2024 23:30:49 -0700
Subject: [PATCH 1/2] [Utils] Add --update-tests to lit
This adds a flag to
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c1c42518c1356e78a10bf252a4a5a643b2bb9efd...5e0817746633736adc7e135160777c8ae39e0e45
clang
hnrklssn wrote:
Note that the first 4 commits are from
https://github.com/llvm/llvm-project/pull/97369; only the last 2 are new. I'll
merge that tomorrow when I have more time to be ready to revert in case
something should happen.
https://github.com/llvm/llvm-project/pull/108425
_
llvmbot wrote:
@llvm/pr-subscribers-testing-tools
Author: Henrik G. Olsson (hnrklssn)
Changes
This adds a flag to lit for detecting and updating failing tests when possible
to do so automatically. The flag uses a plugin architecture where config files
can add additional auto-updaters for
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Henrik G. Olsson (hnrklssn)
Changes
This adds a flag to lit for detecting and updating failing tests when possible
to do so automatically. The flag uses a plugin architecture where config files
can add additional auto-updaters for the typ
24 matches
Mail list logo
