[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

MaskRay wrote: > FTR, got an internal report about this. Luckily it was my turn to catch new > bugs and I recognized the issue. > > @MaskRay Is it too late to add a Release Note for LLVM 18? If it is not too late, #89141 will add it to `release/18.x`. https://github.com/llvm/llvm-project/pull

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

pogo59 wrote: FTR, got an internal report about this. Luckily it was my turn to catch new bugs and I recognized the issue. @MaskRay Is it too late to add a Release Note for LLVM 18? https://github.com/llvm/llvm-project/pull/74809 ___ cfe-commits mail

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

MaskRay wrote: > CC @llvm/clang-vendors > > > I [announced this change on > > discourse](https://discourse.llvm.org/t/use-glob-instead-of-regex-for-specialcaselists/71666?u=ellishg) > > last year. > > "Use glob instead of regex for SpecialCaseLists" doesn't mean anything for > anyone not act

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

pogo59 wrote: > CC @llvm/clang-vendors Thank you for that! I don't know whether our sanitizer guys were aware of this, I've filed an internal ticket to find out. +1 to the complaint about no Release Note. https://github.com/llvm/llvm-project/pull/74809 ___

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

efriedma-quic wrote: CC @llvm/clang-vendors > I [announced this change on > discourse](https://discourse.llvm.org/t/use-glob-instead-of-regex-for-specialcaselists/71666?u=ellishg) > last year. "Use glob instead of regex for SpecialCaseLists" doesn't mean anything for anyone not actively work

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

ellishg wrote: > A report from the field: we had an ignorelist that contained > `[cfi-vcall|cfi-nvcall|cfi-icall]`. This was recommended syntax from the > documentation > (https://releases.llvm.org/17.0.1/tools/clang/docs/SanitizerSpecialCaseList.html)... > but it broke with the transition.

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

efriedma-quic wrote: A report from the field: we had an ignorelist that contained `[cfi-vcall|cfi-nvcall|cfi-icall]`. This was recommended syntax from the documentation (https://releases.llvm.org/17.0.1/tools/clang/docs/SanitizerSpecialCaseList.html)... but it broke with the transition. Thi

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

dwblaikie wrote: (this sort of example reinforces my concerns expressed earlier that this kind of silent change in behavior is problematic - moreso in the wild, rather than in Google's fairly constrained environment (frequent updates, good test coverage, and good bisection infrastructure, etc

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

MaskRay wrote: > ah it's because we something like > > ``` > [cfi-unrelated-cast|cfi-derived-cast] > > src:*third_party/vulkan_memory_allocator/include/vk_mem_alloc.h > ``` > > it seems like the new system doesn't match > `[cfi-unrelated-cast|cfi-derived-cast]` The glob mode can use the sect

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

ellishg wrote: > This caused some ignorelist changes, e.g. > > > > `src:*third_party/vulkan_memory_allocator/include/vk_mem_alloc.h` > > > > didn't work anymore and the opt-out made it work again. Still investigating > why. Not sure if it's the reason, but the `.` in `vk_mem_alloc.h` matc

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

aeubanks wrote: This caused some ignorelist changes, e.g. `src:*third_party/vulkan_memory_allocator/include/vk_mem_alloc.h` didn't work anymore and the opt-out made it work again. Still investigating why. https://github.com/llvm/llvm-project/pull/74809 _

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

dwblaikie wrote: Still seems like an unfortunate and subtle silent change in behavior to me. But *shrug* if folks who own these features think it's fine, so be it. https://github.com/llvm/llvm-project/pull/74809 ___ cfe-commits mailing list cfe-commit

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

https://github.com/ellishg approved this pull request. Looks good to me. Thanks for following up! https://github.com/llvm/llvm-project/pull/74809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes https://reviews.llvm.org/D154014 addes glob support and enables it when `#!special-case-list-v2` is the first line. This patch makes the glob support the default (faster than regex after https://reviews.llvm.o

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/74809 https://reviews.llvm.org/D154014 addes glob support and enables it when `#!special-case-list-v2` is the first line. This patch makes the glob support the default (faster than regex after https://reviews.llvm.org/D