[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

mgorny wrote: Thanks! https://github.com/llvm/llvm-project/pull/96136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

MaskRay wrote: > I suspect this is the root cause that some modules related test are failing > on armv8-quick. It passes with commit > [12c0281](https://github.com/llvm/llvm-project/commit/12c0281f8c73bc1aa20d1517357e0e12c3f8bb4e) > > ([lab.llvm.org/buildbot/#/builders/154/builds/320](https:/

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

mgorny wrote: Also hit it on 32-bit x86; filed #96379 before I managed to bisect it. https://github.com/llvm/llvm-project/pull/96136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

ChuanqiXu9 wrote: I suspect this is the root cause that some modules related test are failing on armv8-quick. It passes with commit 12c0281f8c73bc1aa2 (https://lab.llvm.org/buildbot/#/builders/154/builds/320) and fails with b39f523af7601fe1b39b3256 (https://lab.llvm.org/buildbot/#/builders/15

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/96136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

https://github.com/ChuanqiXu9 approved this pull request. LGTM then. https://github.com/llvm/llvm-project/pull/96136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

MaskRay wrote: > > > This looks generally good. > > Which tests are still failing? OK. 12c0281f8c73bc1aa20d1517357e0e12c3f8bb4e has fixed these failures. If this PR is applied as well, applying https://github.com/MaskRay/llvm-project/tree/hashing-seed will not cause `check-clang` failures. h

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

MaskRay wrote: - [ ] Clang :: APINotes/module-cache.m - [ ] Clang :: Driver/cuda-bindings.cu - [ ] Clang :: Driver/cuda-phases.cu - [ ] Clang :: Driver/hip-phases.hip - [ ] Clang :: Driver/hip-toolchain-no-rdc.hip - [ ] Clang :: Driver/openmp-system-arch.c - [ ] Clang :: Modules/Rmodule-bu

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

ChuanqiXu9 wrote: > > This looks generally good. > > > Some check-clang-modules tests still fail (@ChuanqiXu9) > > > > > > What does this mean? Do you mean there are some failures after this patch? > > What are they? Or are these tests failing before this patch? > > When https://github.com/Ma

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

MaskRay wrote: > This looks generally good. > > > Some check-clang-modules tests still fail (@ChuanqiXu9) > > What does this mean? Do you mean there are some failures after this patch? > What are they? Or are these tests failing before this patch? When https://github.com/MaskRay/llvm-project/

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

ChuanqiXu9 wrote: This looks generally good. > Some check-clang-modules tests still fail (@ChuanqiXu9) What does this mean? Do you mean there are some failures after this patch? What are they? Or are these tests failing before this patch? https://github.com/llvm/llvm-project/pull/96136 _

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

MaskRay wrote: This patch fixes most clangSerialization issues if we make `llvm::hash_combine`/`llvm::hash_value` non-deterministic. https://github.com/MaskRay/llvm-project/tree/hashing-seed Some check-clang-modules tests still fail (@ChuanqiXu9) along with other failures (e.g. HIP @jhuber6 )

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Fangrui Song (MaskRay) Changes clangSerialization currently uses hash_combine/hash_value from Hashing.h, which are not guaranteed to be deterministic. Replace these uses with xxh3_64bits. --- Full diff: https://github.com/llvm/llv

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/96136 clangSerialization currently uses hash_combine/hash_value from Hashing.h, which are not guaranteed to be deterministic. Replace these uses with xxh3_64bits. >From 8faa9f42a01a3a832cb197465a68f02f9c0f3509 Mon Sep