[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang,llvm` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11921 Here is the relevant

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/122839 >From fb1c27ea34d42b9c141fe9a2d1a5ad8584dfa0a0 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 9 Jan 2025 19:19:27 -0500 Subject: [PATCH 1/7] [SPIRV] add pre legalization instruction combine - Add the bo

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Vyacheslav Levytskyy via cfe-commits
@@ -1,33 +1,44 @@ -; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s -; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %} - -; Make sure SPIRV operation function calls for distance are lowered correctly. - -; CH

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Vyacheslav Levytskyy via cfe-commits
https://github.com/VyacheslavLevytskyy approved this pull request. https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > @farzonl Was enabled GISelCSEAnalysisWrapperPass a reason of problems with > inline_asm? It was CSE and The combiner pass does dead code elimination. I removed one and turned the other off. Their is a bug in the SPIRVPreLegalizer where its expecting a matching number of inlin

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Vyacheslav Levytskyy via cfe-commits
VyacheslavLevytskyy wrote: @farzonl Was enabled GISelCSEAnalysisWrapperPass a reason of problems with inline_asm? https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/122839 >From fb1c27ea34d42b9c141fe9a2d1a5ad8584dfa0a0 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 9 Jan 2025 19:19:27 -0500 Subject: [PATCH 1/6] [SPIRV] add pre legalization instruction combine - Add the bo

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl ready_for_review https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/122839 >From fb1c27ea34d42b9c141fe9a2d1a5ad8584dfa0a0 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 9 Jan 2025 19:19:27 -0500 Subject: [PATCH 1/5] [SPIRV] add pre legalization instruction combine - Add the bo

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/122839 >From fb1c27ea34d42b9c141fe9a2d1a5ad8584dfa0a0 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 9 Jan 2025 19:19:27 -0500 Subject: [PATCH 1/5] [SPIRV] add pre legalization instruction combine - Add the bo

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Steven Perron via cfe-commits
https://github.com/s-perron approved this pull request. I don't see any problem, but I'm not familiar with standard practices in llvm. I like having the combiner pass. https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-c

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,140 @@ +; RUN: llc -mtriple=spirv-unknown-unknown -debug-pass=Structure < %s -o /dev/null 2>&1 | \ farzonl wrote: I'm using this test case to help me figure out why I'm seeing an assert fire in `SPV_INTEL_inline_assembly/inline_asm.ll`. I can remove

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl converted_to_draft https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-17 Thread Vyacheslav Levytskyy via cfe-commits
@@ -0,0 +1,140 @@ +; RUN: llc -mtriple=spirv-unknown-unknown -debug-pass=Structure < %s -o /dev/null 2>&1 | \ VyacheslavLevytskyy wrote: Just as a thought aloud, I wonder how stable this list can be at this stage of SPIR-V Backend development? I guess this test

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/122839 >From fb1c27ea34d42b9c141fe9a2d1a5ad8584dfa0a0 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 9 Jan 2025 19:19:27 -0500 Subject: [PATCH 1/4] [SPIRV] add pre legalization instruction combine - Add the bo

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl deleted https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,260 @@ + +//===-- SPIRVPreLegalizerCombiner.cpp - combine legalization *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/122839 >From fb1c27ea34d42b9c141fe9a2d1a5ad8584dfa0a0 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 9 Jan 2025 19:19:27 -0500 Subject: [PATCH 1/4] [SPIRV] add pre legalization instruction combine - Add the bo

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Vyacheslav Levytskyy via cfe-commits
VyacheslavLevytskyy wrote: > I rebased and the tests are passing locally. but they are still failing in ci. It's the strange part. The thing is when I created a new https://github.com/llvm/llvm-project/pull/123191 today, I see all tests passing in CI before I press Merged. That's why I thought

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > > > > I see also some problems in test cases > > > > > > > > > @VyacheslavLevytskyy the SPIRV test case failures are not related to my > > > change. They are also failing on main. > > > > > > I will check now. For one the reason is clear, #123191 > > I can't reproduce two o

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/122839 >From 67d9c51dbd0cf78f4cf622f655adb76d519b774b Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 9 Jan 2025 19:19:27 -0500 Subject: [PATCH 1/3] [SPIRV] add pre legalization instruction combine - Add the bo

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Vyacheslav Levytskyy via cfe-commits
VyacheslavLevytskyy wrote: > > > I see also some problems in test cases > > > > > > @VyacheslavLevytskyy the SPIRV test case failures are not related to my > > change. They are also failing on main. > > I will check now. For one the reason is clear, #123191 I can't reproduce two other fails

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Vyacheslav Levytskyy via cfe-commits
VyacheslavLevytskyy wrote: > > I see also some problems in test cases > > @VyacheslavLevytskyy the SPIRV test case failures are not related to my > change. They are also failing on main. I will check now. For one the reason is clear, https://github.com/llvm/llvm-project/pull/123191 https://g

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > I see also some problems in test cases @VyacheslavLevytskyy the SPIRV test case failures are not related to my change. They are also failing on main. https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-c

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Vyacheslav Levytskyy via cfe-commits
VyacheslavLevytskyy wrote: I see also some problems in test cases https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-16 Thread Vyacheslav Levytskyy via cfe-commits
VyacheslavLevytskyy wrote: @farzonl Thank you for adding instcombine/pattern matching capabilities. LGTM overall. Maybe we should also document each transformation a bit in comments to the corresponding function, so that we clearly see what kind of input we expect to see to run the substitutio

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-15 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/122839 >From ae1a274f856518d710cffba324c603d9e95adf54 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 9 Jan 2025 19:19:27 -0500 Subject: [PATCH 1/2] [SPIRV] add pre legalization instruction combine - Add the bo

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-15 Thread Michal Paszkowski via cfe-commits
@@ -0,0 +1,26 @@ +//=- SPIRVCombine.td - Define SPIRV Combine Rules -*-tablegen -*-=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-14 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl ready_for_review https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-14 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/122839 >From ae1a274f856518d710cffba324c603d9e95adf54 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 9 Jan 2025 19:19:27 -0500 Subject: [PATCH] [SPIRV] add pre legalization instruction combine - Add the boiler

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-14 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl converted_to_draft https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-13 Thread Farzon Lotfi via cfe-commits
@@ -1,33 +1,44 @@ -; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s farzonl wrote: changed line endings from crlf to lf. https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list