[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

https://github.com/AlexMaclean closed https://github.com/llvm/llvm-project/pull/134416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

github-actions[bot] wrote: @YonahGoldberg Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

AlexMaclean wrote: Merging on behalf of @YonahGoldberg at his request offline. https://github.com/llvm/llvm-project/pull/134416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

https://github.com/Artem-B approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/134416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

@@ -1,26 +1,53 @@ -; Verify that when passing in command-line options to NVVMReflect, that reflect calls are replaced with -; the appropriate command line values. +; Test the NVVM reflect pass functionality: verifying that reflect calls are replaced with +; appropriate values b

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

@@ -1,26 +1,53 @@ -; Verify that when passing in command-line options to NVVMReflect, that reflect calls are replaced with -; the appropriate command line values. +; Test the NVVM reflect pass functionality: verifying that reflect calls are replaced with +; appropriate values b

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

@@ -1,26 +1,53 @@ -; Verify that when passing in command-line options to NVVMReflect, that reflect calls are replaced with -; the appropriate command line values. +; Test the NVVM reflect pass functionality: verifying that reflect calls are replaced with +; appropriate values b

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

@@ -1,26 +1,53 @@ -; Verify that when passing in command-line options to NVVMReflect, that reflect calls are replaced with -; the appropriate command line values. +; Test the NVVM reflect pass functionality: verifying that reflect calls are replaced with +; appropriate values b

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

@@ -1,26 +1,53 @@ -; Verify that when passing in command-line options to NVVMReflect, that reflect calls are replaced with -; the appropriate command line values. +; Test the NVVM reflect pass functionality: verifying that reflect calls are replaced with +; appropriate values b

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

https://github.com/Artem-B commented: Almost there. Few more test nits. https://github.com/llvm/llvm-project/pull/134416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/134416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

@@ -1,26 +1,53 @@ -; Verify that when passing in command-line options to NVVMReflect, that reflect calls are replaced with -; the appropriate command line values. +; Test the NVVM reflect pass functionality: verifying that reflect calls are replaced with +; appropriate values b

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

@@ -0,0 +1,26 @@ +; Verify that when passing in command-line options to NVVMReflect, that reflect calls are replaced with +; the appropriate command line values. + +declare i32 @__nvvm_reflect(ptr) +@ftz = private unnamed_addr addrspace(1) constant [11 x i8] c"__CUDA_FTZ\00" +@ar

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

@@ -0,0 +1,26 @@ +; Verify that when passing in command-line options to NVVMReflect, that reflect calls are replaced with Artem-B wrote: The test is functionally fine, but it also makes me stop and think "what exactly are we doing here and why?". Two points: -

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

@@ -39,186 +39,201 @@ #include "llvm/Transforms/Scalar.h" #include "llvm/Transforms/Utils/BasicBlockUtils.h" #include "llvm/Transforms/Utils/Local.h" -#include #define NVVM_REFLECT_FUNCTION "__nvvm_reflect" #define NVVM_REFLECT_OCL_FUNCTION "__nvvm_reflect_ocl" +// Argument

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

https://github.com/Artem-B approved this pull request. LGTM for the code. Tests could use a bit more polishing. https://github.com/llvm/llvm-project/pull/134416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/134416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Improve NVVMReflect Efficiency (PR #134416)

https://github.com/AlexMaclean approved this pull request. LGTM, please wait for @Artem-B's approval before landing. https://github.com/llvm/llvm-project/pull/134416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin