[clang] [llvm] [NFC][HLSL] Move emitter out of AMDGPU.cpp (PR #133251)

2025-03-27 Thread Ashley Coleman via cfe-commits
https://github.com/V-FEXrt approved this pull request. https://github.com/llvm/llvm-project/pull/133251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][HLSL] Move emitter out of AMDGPU.cpp (PR #133251)

2025-03-27 Thread Matt Arsenault via cfe-commits
@@ -115,6 +115,7 @@ add_clang_library(clangCodeGen PatternInit.cpp SanitizerMetadata.cpp SwiftCallingConv.cpp + LangBuiltins/CGHLSLBuiltins.cpp arsenm wrote: I wouldn't bother with the LangBuiltins subdirectory https://github.com/llvm/llvm-project/pul

[clang] [llvm] [NFC][HLSL] Move emitter out of AMDGPU.cpp (PR #133251)

2025-03-27 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/133251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][HLSL] Move emitter out of AMDGPU.cpp (PR #133251)

2025-03-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Farzon Lotfi (farzonl) Changes - Create a home for LangBuiltins - Move all HLSL code out of AMDGPU.cpp to CGHLSLBuiltins.cpp --- Patch is 63.61 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/133

[clang] [llvm] [NFC][HLSL] Move emitter out of AMDGPU.cpp (PR #133251)

2025-03-27 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > Thanks for creating this PR, LGTM (I wasn't able to do it earlier as one of > my kids was ill, so away from laptop) No worries. Thanks for the approval! https://github.com/llvm/llvm-project/pull/133251 ___ cfe-commits mailing list cf

[clang] [llvm] [NFC][HLSL] Move emitter out of AMDGPU.cpp (PR #133251)

2025-03-27 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. Thanks for creating this PR, LGTM (I wasn't able to do it earlier as one of my kids was ill, so away from laptop) https://github.com/llvm/llvm-project/pull/133251 ___ cfe-commits mailing list cf

[clang] [llvm] [NFC][HLSL] Move emitter out of AMDGPU.cpp (PR #133251)

2025-03-27 Thread Farzon Lotfi via cfe-commits
@@ -115,6 +115,7 @@ add_clang_library(clangCodeGen PatternInit.cpp SanitizerMetadata.cpp SwiftCallingConv.cpp + LangBuiltins/CGHLSLBuiltins.cpp farzonl wrote: done! https://github.com/llvm/llvm-project/pull/133251 __

[clang] [llvm] [NFC][HLSL] Move emitter out of AMDGPU.cpp (PR #133251)

2025-03-27 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/133251 >From b7cca5e5606382ba8b9e971f0554036c03b22c60 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 27 Mar 2025 09:44:44 -0400 Subject: [PATCH 1/2] [NFC][HLSL] Move emitter out of AMDGPU.cpp - Create a home f

[clang] [llvm] [NFC][HLSL] Move emitter out of AMDGPU.cpp (PR #133251)

2025-03-27 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/133251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][HLSL] Move emitter out of AMDGPU.cpp (PR #133251)

2025-03-27 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/133251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][HLSL] Move emitter out of AMDGPU.cpp (PR #133251)

2025-03-27 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/133251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][HLSL] Move emitter out of AMDGPU.cpp (PR #133251)

2025-03-27 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/133251 - Create a home for LangBuiltins - Move all HLSL code out of AMDGPU.cpp to CGHLSLBuiltins.cpp >From b7cca5e5606382ba8b9e971f0554036c03b22c60 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 27 Mar 2025 09