https://github.com/aengelke closed
https://github.com/llvm/llvm-project/pull/103025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
Thanks for the cleanup!
https://github.com/llvm/llvm-project/pull/103025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -109,7 +109,6 @@ initializeRecordStreamer(const Module &M,
MCContext MCCtx(TT, MAI.get(), MRI.get(), STI.get(), &SrcMgr);
std::unique_ptr MOFI(
T->createMCObjectFileInfo(MCCtx, /*PIC=*/false));
- MOFI->setSDKVersion(M.getSDKVersion());
aengelke wr
@@ -559,6 +559,9 @@ int main(int argc, char **argv) {
std::unique_ptr(CE), *STI));
if (NoExecStack)
Str->initSections(true, *STI);
+if (TheTriple.isOSBinFormatMachO() && TheTriple.isOSDarwin())
aengelke wrote:
No. I just put it in front o
https://github.com/aengelke updated
https://github.com/llvm/llvm-project/pull/103025
>From 90c48050f1e56613a4a68056e608de5fdc3e9cb6 Mon Sep 17 00:00:00 2001
From: Alexis Engelke
Date: Tue, 13 Aug 2024 09:08:15 +
Subject: [PATCH 1/2] [MC] Remove Darwin SDK/Version from ObjFileInfo
There's o
@@ -109,7 +109,6 @@ initializeRecordStreamer(const Module &M,
MCContext MCCtx(TT, MAI.get(), MRI.get(), STI.get(), &SrcMgr);
std::unique_ptr MOFI(
T->createMCObjectFileInfo(MCCtx, /*PIC=*/false));
- MOFI->setSDKVersion(M.getSDKVersion());
MaskRay wro
@@ -559,6 +559,9 @@ int main(int argc, char **argv) {
std::unique_ptr(CE), *STI));
if (NoExecStack)
Str->initSections(true, *STI);
+if (TheTriple.isOSBinFormatMachO() && TheTriple.isOSDarwin())
MaskRay wrote:
Is this needed? It seems that
llvmbot wrote:
@llvm/pr-subscribers-mc
Author: Alexis Engelke (aengelke)
Changes
There's only a single user (MCMachOStreamer), so it makes more sense to move
the version emission to the source of the data.
(Not sure whether we want this, but I don't see benefits in storing this
informat
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-llvm-binary-utilities
Author: Alexis Engelke (aengelke)
Changes
There's only a single user (MCMachOStreamer), so it makes more sense to move
the version emission to the source of the data.
(Not sure whether we want this, but
https://github.com/aengelke created
https://github.com/llvm/llvm-project/pull/103025
There's only a single user (MCMachOStreamer), so it makes more sense to move
the version emission to the source of the data.
(Not sure whether we want this, but I don't see benefits in storing this
informatio
10 matches
Mail list logo
