https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/88750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zixu-w approved this pull request.
https://github.com/llvm/llvm-project/pull/88750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -259,7 +259,10 @@ bool Options::processLinkerOptions(InputArgList &Args) {
if (auto *Arg = Args.getLastArg(drv::OPT_umbrella))
LinkerOpts.ParentUmbrella = Arg->getValue();
- LinkerOpts.IsDylib = Args.hasArg(drv::OPT_dynamiclib);
cyndyishida wrote:
n
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88750
>From b2b54ad8ccf930a19327563a64c52c9f4013103f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 13:13:45 -0700
Subject: [PATCH 1/4] [InstallAPI] Add support for aliased exports
Apple's ld s
@@ -259,7 +259,10 @@ bool Options::processLinkerOptions(InputArgList &Args) {
if (auto *Arg = Args.getLastArg(drv::OPT_umbrella))
LinkerOpts.ParentUmbrella = Arg->getValue();
- LinkerOpts.IsDylib = Args.hasArg(drv::OPT_dynamiclib);
zixu-w wrote:
Is thi
cyndyishida wrote:
ping, is there anything else needed to land this patch?
https://github.com/llvm/llvm-project/pull/88750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88750
>From b2b54ad8ccf930a19327563a64c52c9f4013103f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 13:13:45 -0700
Subject: [PATCH 1/3] [InstallAPI] Add support for aliased exports
Apple's ld s
@@ -973,5 +978,24 @@ bool DylibVerifier::verifyBinaryAttrs(const
ArrayRef ProvidedTargets,
return true;
}
+std::unique_ptr DylibVerifier::getExports() {
+ for (const auto &[Alias, Base] : Aliases) {
ributzka wrote:
In that case I would update the function
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88750
>From b2b54ad8ccf930a19327563a64c52c9f4013103f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 13:13:45 -0700
Subject: [PATCH 1/2] [InstallAPI] Add support for aliased exports
Apple's ld s
@@ -973,5 +978,24 @@ bool DylibVerifier::verifyBinaryAttrs(const
ArrayRef ProvidedTargets,
return true;
}
+std::unique_ptr DylibVerifier::getExports() {
+ for (const auto &[Alias, Base] : Aliases) {
cyndyishida wrote:
`getExports()` only gets called once
@@ -107,6 +107,9 @@ struct LinkerOptions {
/// \brief Additional library search paths.
PathSeq LibPaths;
+ /// \brief List of aliased symbol exports.
ributzka wrote:
```suggestion
/// \brief List of alias symbol files.
```
https://github.com/llvm/llvm
@@ -973,5 +978,24 @@ bool DylibVerifier::verifyBinaryAttrs(const
ArrayRef ProvidedTargets,
return true;
}
+std::unique_ptr DylibVerifier::getExports() {
+ for (const auto &[Alias, Base] : Aliases) {
ributzka wrote:
This loop runs every time someone calls
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88750
>From b2b54ad8ccf930a19327563a64c52c9f4013103f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 13:13:45 -0700
Subject: [PATCH] [InstallAPI] Add support for aliased exports
Apple's ld suppo
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88750
>From d7a4e72f80a9dcd18770dec1e06fd54518b60233 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 13:13:45 -0700
Subject: [PATCH] [InstallAPI] Add support for aliased exports
Apple's ld suppo
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a06073f91e7532e68bbf6b903c2f5051f4c2
3170f89b36ccf3ad6003f24decb282e23951d943 --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Cyndy Ishida (cyndyishida)
Changes
Apple's ld supports alias_lists, described as
```
-alias_list filename
The specified filename contains a list of aliases. The symbol name
and its alias are on one
line, sepa
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/88750
Apple's ld supports alias_lists, described as
```
-alias_list filename
The specified filename contains a list of aliases. The symbol name
and its alias are on one
line, separate
17 matches
Mail list logo
