[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/89775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

pogo59 wrote: Abandoning this. We'll work around the brokenness in our downstream repo. https://github.com/llvm/llvm-project/pull/89775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

pogo59 wrote: > For my toolchain I can continue to carry a patch until this is all sorted. Same here; I'm just professionally offended by the brokenness. But I'm not the right person to drive an RFC. If nobody else is willing to, I'll abandon this and we'll do what we need to downstream to ha

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

tru wrote: I don't have the bandwidth to get a RFC through right now. If this is broken and no-one wants to take care of getting consensus for something new, I suggest you revert to the previous state. For my toolchain I can continue to carry a patch until this is all sorted. https://github.c

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

pogo59 wrote: @MaskRay @tru How do we proceed with this? The current state is broken. https://github.com/llvm/llvm-project/pull/89775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

pogo59 wrote: Thanks for the link. I've put a comment there pointing here, explaining that the current default state (at least on Windows) is broken and that this patch has come to no agreement about how to fix it. https://github.com/llvm/llvm-project/pull/89775 ___

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

MaskRay wrote: > > I want to hear about opinions why the old compiler-rt file hierarchy is > > preferred by some users. > > I think if you really want a range of opinions, you can get them from an RFC. > Not many people will be watching this PR. Perhaps @tru can make another comment to https

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

pogo59 wrote: > I want to hear about opinions why the old compiler-rt file hierarchy is > preferred by some users. I think if you really want a range of opinions, you can get them from an RFC. Not many people will be watching this PR. https://github.com/llvm/llvm-project/pull/89775 __

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

pogo59 wrote: To answer @MaskRay 's question directly, with respect to PlayStation (not Windows, which is the major problem): We have exactly one target, so neither the arch suffix nor a target-specific directory are useful. (Arguably we have two targets, but as we deliver entirely separate S

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

tru wrote: Yeah I think this should be brought up as an RFC in discourse. I would like to see that we move away from two different layouts and just adopt one (my preference is the new layout, but honestly - I don't feel that strongly about it). https://github.com/llvm/llvm-project/pull/89775

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

pogo59 wrote: My understanding is that this change never had a proper Discourse RFC, which means it was quite possible for vendors not to have noticed it. Certainly I (on behalf of Sony) was not aware, and I make some effort to keep an eye on things. There is no good reason to suppose Visual S

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

MaskRay wrote: I want to hear about opinions why the old compiler-rt file hierarchy is preferred by some users. Ideally, all operating systems would eventually migrate to `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on` and adopt a consistent hierarchy similar to libc++/libc++abi/libunwind (without th

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

tru wrote: It needs a release note and documentation though. https://github.com/llvm/llvm-project/pull/89775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

tru wrote: I think this is fine. I probably have to carry a one line patch in our tree to make it the default on windows as well. But that's acceptable to me. https://github.com/llvm/llvm-project/pull/89775 ___ cfe-commits mailing list cfe-commits@li

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

pogo59 wrote: @mstorsjo On reflection I agree that a build-time choice for handling this is not appropriate. It really wants to be target-based. Latest version (a) falls back to old style for Windows/PS as well as AIX, (b) adds a driver option to influence that default. @MaskRay @tru @nico PT

[clang] [llvm] [Driver] Add option to select compiler-rt arch suffix (PR #89775)

https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/89775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits