chapuni wrote:
@Lambdaris I have #112730 as well.
https://github.com/llvm/llvm-project/pull/112694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Lambdaris wrote:
This patch also helps to distinguish constants from rust, in which constant may
have only one counter hard coded to `Zero`, thank you!
Besides, I found that with this change we should also count false counter id
when [calculating max
`CounterID`](https://github.com/llvm/llvm-
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building
`clang,llvm` at step 7 "Add check check-offload".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/30/builds/8580
Here is the re
https://github.com/chapuni closed
https://github.com/llvm/llvm-project/pull/112694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -125,7 +125,7 @@ json::Array renderRegions(ArrayRef
Regions) {
json::Array renderBranchRegions(ArrayRef Regions) {
json::Array RegionArray;
for (const auto &Region : Regions)
-if (!Region.Folded)
+if (!Region.TrueFolded || !Region.FalseFolded)
c
https://github.com/chapuni updated
https://github.com/llvm/llvm-project/pull/112694
>From ea3e2df8c712ae5da77e55a14e97b1b6855a6b76 Mon Sep 17 00:00:00 2001
From: NAKAMURA Takumi
Date: Sun, 6 Oct 2024 10:11:54 +0900
Subject: [PATCH 1/2] [Coverage] Introduce "partial fold" on BranchRegion
Curren
https://github.com/evodius96 approved this pull request.
https://github.com/llvm/llvm-project/pull/112694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
evodius96 wrote:
I think this is a meaningful enhancement to branch coverage. I don't have much
to add to what's been said. LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/112694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
@@ -19,18 +19,18 @@ using namespace coverage;
static void sumBranches(size_t &NumBranches, size_t &CoveredBranches,
const ArrayRef &Branches) {
for (const auto &BR : Branches) {
-// Skip folded branches.
-if (BR.Folded)
- continue;
-
-
hanickadot wrote:
I have no additional list of thing Jessica pointed out, LGTM
https://github.com/llvm/llvm-project/pull/112694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hanickadot approved this pull request.
https://github.com/llvm/llvm-project/pull/112694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -719,10 +720,10 @@ struct FunctionRecord {
Region.Kind == CounterMappingRegion::MCDCBranchRegion) {
CountedBranchRegions.emplace_back(Region, Count, FalseCount,
HasSingleByteCoverage);
- // If both counters are hard-
https://github.com/chapuni commented:
Thanks for comments!
https://github.com/llvm/llvm-project/pull/112694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hanickadot wrote:
Do you have example before/after of the change? It's a bit hard to imagine.
https://github.com/llvm/llvm-project/pull/112694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
@@ -19,18 +19,18 @@ using namespace coverage;
static void sumBranches(size_t &NumBranches, size_t &CoveredBranches,
const ArrayRef &Branches) {
for (const auto &BR : Branches) {
-// Skip folded branches.
-if (BR.Folded)
- continue;
-
-
@@ -125,7 +125,7 @@ json::Array renderRegions(ArrayRef
Regions) {
json::Array renderBranchRegions(ArrayRef Regions) {
json::Array RegionArray;
for (const auto &Region : Regions)
-if (!Region.Folded)
+if (!Region.TrueFolded || !Region.FalseFolded)
c
https://github.com/chapuni edited
https://github.com/llvm/llvm-project/pull/112694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -19,18 +19,18 @@ using namespace coverage;
static void sumBranches(size_t &NumBranches, size_t &CoveredBranches,
const ArrayRef &Branches) {
for (const auto &BR : Branches) {
-// Skip folded branches.
-if (BR.Folded)
- continue;
-
-
@@ -125,7 +125,7 @@ json::Array renderRegions(ArrayRef
Regions) {
json::Array renderBranchRegions(ArrayRef Regions) {
json::Array RegionArray;
for (const auto &Region : Regions)
-if (!Region.Folded)
+if (!Region.TrueFolded || !Region.FalseFolded)
o
@@ -19,18 +19,18 @@ using namespace coverage;
static void sumBranches(size_t &NumBranches, size_t &CoveredBranches,
const ArrayRef &Branches) {
for (const auto &BR : Branches) {
-// Skip folded branches.
-if (BR.Folded)
- continue;
-
-
@@ -719,10 +720,10 @@ struct FunctionRecord {
Region.Kind == CounterMappingRegion::MCDCBranchRegion) {
CountedBranchRegions.emplace_back(Region, Count, FalseCount,
HasSingleByteCoverage);
- // If both counters are hard-
@@ -719,10 +720,10 @@ struct FunctionRecord {
Region.Kind == CounterMappingRegion::MCDCBranchRegion) {
CountedBranchRegions.emplace_back(Region, Count, FalseCount,
HasSingleByteCoverage);
- // If both counters are hard-
@@ -719,10 +720,10 @@ struct FunctionRecord {
Region.Kind == CounterMappingRegion::MCDCBranchRegion) {
CountedBranchRegions.emplace_back(Region, Count, FalseCount,
HasSingleByteCoverage);
- // If both counters are hard-
llvmbot wrote:
@llvm/pr-subscribers-pgo
Author: NAKAMURA Takumi (chapuni)
Changes
Currently both True/False counts were folded. It lost the information, "It is
True or False before folding." It prevented recalling branch counts in merging
template instantiations.
In `llvm-cov`, a folded
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: NAKAMURA Takumi (chapuni)
Changes
Currently both True/False counts were folded. It lost the information, "It is
True or False before folding." It prevented recalling branch counts in merging
template instantiations.
In `llvm-cov`
https://github.com/chapuni created
https://github.com/llvm/llvm-project/pull/112694
Currently both True/False counts were folded. It lost the information, "It is
True or False before folding." It prevented recalling branch counts in merging
template instantiations.
In `llvm-cov`, a folded bra
26 matches
Mail list logo
