github-actions[bot] wrote:
@jwestwood921 Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a b
https://github.com/ostannard closed
https://github.com/llvm/llvm-project/pull/81493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jwestwood921 updated
https://github.com/llvm/llvm-project/pull/81493
>From 0a970c1e8d5137e1c202f688f06d738b890dd98c Mon Sep 17 00:00:00 2001
From: James Westwood
Date: Fri, 9 Feb 2024 19:06:20 +
Subject: [PATCH] __ARM_ARCH macro definition fix
This patch changes how the
https://github.com/jwestwood921 updated
https://github.com/llvm/llvm-project/pull/81493
>From 0a970c1e8d5137e1c202f688f06d738b890dd98c Mon Sep 17 00:00:00 2001
From: James Westwood
Date: Fri, 9 Feb 2024 19:06:20 +
Subject: [PATCH] __ARM_ARCH macro definition fix
This patch changes how the
davemgreen wrote:
I'm a little worried people might be relying on the existing behaviour, with
both clang and GCC having this wrong for a while. If we are going to do it can
you add a release note to clang explaining the new behaviour?
https://github.com/llvm/llvm-project/pull/81493
__
https://github.com/jwestwood921 updated
https://github.com/llvm/llvm-project/pull/81493
>From 15c83444dbf0ea8e161479253351727b049b6bd1 Mon Sep 17 00:00:00 2001
From: James Westwood
Date: Fri, 9 Feb 2024 19:06:20 +
Subject: [PATCH] __ARM_ARCH macro definition fix
This patch changes how the
https://github.com/jwestwood921 updated
https://github.com/llvm/llvm-project/pull/81493
>From 2c265033c4f345f475a7dca4793178ce2502a4fa Mon Sep 17 00:00:00 2001
From: James Westwood
Date: Fri, 9 Feb 2024 19:06:20 +
Subject: [PATCH 1/2] __ARM_ARCH macro definition fix
This patch changes how
https://github.com/ostannard edited
https://github.com/llvm/llvm-project/pull/81493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -736,9 +737,17 @@ void ARMTargetInfo::getTargetDefines(const LangOptions
&Opts,
if (!CPUAttr.empty())
Builder.defineMacro("__ARM_ARCH_" + CPUAttr + "__");
- // ACLE 6.4.1 ARM/Thumb instruction set architecture
- // __ARM_ARCH is defined as an integer value indicati
https://github.com/ostannard approved this pull request.
LGTM, just some minor changes to the comments which don't need re-review.
https://github.com/llvm/llvm-project/pull/81493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
@@ -367,8 +367,21 @@ void AArch64TargetInfo::getTargetDefines(const LangOptions
&Opts,
// ACLE predefines. Many can only have one possible value on v8 AArch64.
Builder.defineMacro("__ARM_ACLE", "200");
- Builder.defineMacro("__ARM_ARCH",
- std::to_st
pinskia wrote:
Note the corresponding GCC bug is at
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99312 (and there was a patch
posted but never reviewed;
https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566322.html).
https://github.com/llvm/llvm-project/pull/81493
_
https://github.com/jwestwood921 edited
https://github.com/llvm/llvm-project/pull/81493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
13 matches
Mail list logo
