[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

kimgr wrote: Thanks! https://github.com/llvm/llvm-project/pull/103388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

https://github.com/tuliom closed https://github.com/llvm/llvm-project/pull/103388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

tuliom wrote: Agreed. Let me merge this. https://github.com/llvm/llvm-project/pull/103388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

kimgr wrote: > > Do we need anything more to make progress with this PR? > > @kimgr Do you have committer permission? Would you like some help to get this > merged? Oh, no, I don't, I would need someone to merge this for me. It's still pretty early in the v.20 cycle, right, so maybe this is a

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

kimgr wrote: > > Is there an out-of-tree scenario where CLANG_RESOURCE_DIR needs to be > > replaced with something else at runtime, i.e. a real use-case for the > > optional CustomResourceDir optional argument I removed? > > @kimgr I have also looked for this and I haven't found an use-case wh

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

tuliom wrote: > Do we need anything more to make progress with this PR? @kimgr Do you have committer permission? Would you like some help to get this merged? https://github.com/llvm/llvm-project/pull/103388 ___ cfe-commits mailing list cfe-commits@li

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

tuliom wrote: > Is there an out-of-tree scenario where CLANG_RESOURCE_DIR needs to be > replaced with something else at runtime, i.e. a real use-case for the > optional CustomResourceDir optional argument I removed? @kimgr I have also looked for this and I haven't found an use-case where this

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

kimgr wrote: Do we need anything more to make progress with this PR? My own primary concerns are basically things I can't check myself: * Is there an out-of-tree scenario where `CLANG_RESOURCE_DIR` needs to be replaced with something else at runtime, i.e. a real use-case for the optional `Cus

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

https://github.com/MaskRay approved this pull request. clangDriver changes look reasonable. https://github.com/llvm/llvm-project/pull/103388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

https://github.com/bulbazord approved this pull request. The LLDB changes look good to me. I can't speak for the clang portions but fwiw I think they look ok too. https://github.com/llvm/llvm-project/pull/103388 ___ cfe-commits mailing list cfe-commit

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

kimgr wrote: @nico You're the original author of this thing back in 2019, maybe you have some additional information. Please take a look if you have a chance. https://github.com/llvm/llvm-project/pull/103388 ___ cfe-commits mailing list cfe-commits@li

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

https://github.com/kimgr updated https://github.com/llvm/llvm-project/pull/103388 From 3722d673ee409c1320c9d66aa2f3f6568ffdfd77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kim=20Gr=C3=A4sman?= Date: Mon, 5 Aug 2024 11:49:32 +0200 Subject: [PATCH] Use CLANG_RESOURCE_DIR more consistently When Clan

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4377656f2419a8eb18c01e86929b689dcf22b5d6 102517cd9d53695c9ae56135492bab09df9d90ee --e

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Kim Gräsman (kimgr) Changes When Clang is consumed as a library, the CLANG_RESOURCE_DIR definition is not exported from the CMake system, so external clients will be unable to compute the same resource dir as Clang itself would, because t

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Kim Gräsman (kimgr) Changes When Clang is consumed as a library, the CLANG_RESOURCE_DIR definition is not exported from the CMake system, so external clients will be unable to compute the same resource dir as Clang itself would, be

[clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

https://github.com/kimgr created https://github.com/llvm/llvm-project/pull/103388 When Clang is consumed as a library, the CLANG_RESOURCE_DIR definition is not exported from the CMake system, so external clients will be unable to compute the same resource dir as Clang itself would, because the