[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2025-01-17 Thread Pavel Labath via cfe-commits
labath wrote: (I'm going to remove all the labels to try to avoid pinging everyone each time you rebase) https://github.com/llvm/llvm-project/pull/102601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-11-26 Thread Dhruv Srivastava via cfe-commits
DhruvSrivastavaX wrote: > BTW, the main loop changes are something that you should be able to upstream > quite easily. It sounds like the main problem is that you don't have a ppoll > syscall, but the last round of changes means that ppoll is not actually > necessary for its operation (the onl

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-11-19 Thread Pavel Labath via cfe-commits
labath wrote: BTW, the main loop changes are something that you should be able to upstream quite easily. It sounds like the main problem is that you don't have a ppoll syscall, but the last round of changes means that ppoll is not actually necessary for its operation (the only reason to use it

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-12 Thread via cfe-commits
https://github.com/Dhruv-Srivastava-IBM edited https://github.com/llvm/llvm-project/pull/102601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-12 Thread via cfe-commits
https://github.com/Dhruv-Srivastava-IBM converted_to_draft https://github.com/llvm/llvm-project/pull/102601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/102601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
@@ -38,6 +38,10 @@ endif() include(LLDBConfig) include(AddLLDB) +if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX") + add_definitions("-D__AIX__") DavidSpickett wrote: Also remember that users may be debugging AIX from a non-AIX host where the compiler would

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
@@ -0,0 +1,7 @@ + +This product contains small piece of code to support AIX, taken from netbsd. + + * LICENSE: +* lldb/source/Host/common/LICENSE.aix-netbsd.txt (OpenSSL License) DavidSpickett wrote: And if there is a way not to pull in this code, we're like

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
@@ -67,6 +67,10 @@ class RegisterContextUnwind : public lldb_private::RegisterContext { bool ReadPC(lldb::addr_t &start_pc); +#ifdef __AIX__ + bool ReadLR(lldb::addr_t &lr); +#endif + DavidSpickett wrote: It's likely we'd ask you to make this a method on

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
@@ -0,0 +1,7 @@ + +This product contains small piece of code to support AIX, taken from netbsd. + + * LICENSE: +* lldb/source/Host/common/LICENSE.aix-netbsd.txt (OpenSSL License) DavidSpickett wrote: We'll need to confirm license compatibility for this. htt

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
@@ -0,0 +1,62 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
@@ -342,7 +342,7 @@ uint32_t SBBreakpoint::GetIgnoreCount() const { return count; } -void SBBreakpoint::SetThreadID(tid_t tid) { +void SBBreakpoint::SetThreadID(lldb::tid_t tid) { DavidSpickett wrote: If these lldb:: are fixing compilation errors they would

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
@@ -1510,6 +1510,18 @@ bool Module::SetLoadAddress(Target &target, lldb::addr_t value, return false; } +bool Module::SetLoadAddressByType(Target &target, lldb::addr_t value, +bool value_is_offset, bool &changed, int type_id) { + ObjectFile *obje

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
@@ -40,6 +40,113 @@ add_custom_target(lldb-sbapi-dwarf-enums DEPENDS ${sb_languages_file}) set_target_properties(lldb-sbapi-dwarf-enums PROPERTIES FOLDER "LLDB/Tablegenning") +if(CMAKE_SYSTEM_NAME MATCHES "AIX") +add_lldb_library(liblldb STATIC ${option_framework} -

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett commented: It's worth putting the PR into draft mode just to be extra clear this is a request for early feedback. This PR will be later split up of course, so very general comments from me. Very impressive effort overall. https://github.com/llvm/llvm-project/p

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
@@ -11,6 +11,11 @@ #include "lldb/Host/Config.h" +#if defined(__AIX__) +//FIXME for AIX +#undef LLDB_ENABLE_LIBXML2 DavidSpickett wrote: In theory if you configure with `-DLLDB_ENABLE_LIBXML2=OFF`, the libxml2 parts will be removed. Was something else being

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
@@ -38,6 +38,10 @@ endif() include(LLDBConfig) include(AddLLDB) +if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX") + add_definitions("-D__AIX__") DavidSpickett wrote: This looks like a macro that a compiler might set for you, is that not the case here? http

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/102601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread via cfe-commits
https://github.com/Dhruv-Srivastava-IBM edited https://github.com/llvm/llvm-project/pull/102601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Dhruv-Srivastava-IBM) Changes We have Implemented the necessary code changes required to run LLDB on AIX. This PR is for discussion as asked in #101657 With this PR, we request your inputs and feedback about our code changes. ---

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-binary-utilities @llvm/pr-subscribers-clang-codegen Author: None (Dhruv-Srivastava-IBM) Changes We have Implemented the necessary code changes required to run LLDB on AIX. This PR is for discussion as asked in #101657 With this PR, we request your

[clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it