https://github.com/jayfoad approved this pull request.
LGTM.
Could also update `flang/cmake/modules/AddFlangOffloadRuntime.cmake` but I
don't really know if it's our responsibility to update Flang.
https://github.com/llvm/llvm-project/pull/94534
___
@@ -1534,6 +1534,12 @@ def FeatureISAVersion11_5_1 : FeatureSet<
FeatureVGPRSingleUseHintInsts,
Feature1_5xVGPRs])>;
+def FeatureISAVersion11_5_2 : FeatureSet<
jayfoad wrote:
I don't have a good answer to this except "it's what we normally do". Othe
@@ -1534,6 +1534,12 @@ def FeatureISAVersion11_5_1 : FeatureSet<
FeatureVGPRSingleUseHintInsts,
Feature1_5xVGPRs])>;
+def FeatureISAVersion11_5_2 : FeatureSet<
rampitec wrote:
Then I defer review to Jay.
https://github.com/llvm/llvm-project/pull/94
@@ -1534,6 +1534,12 @@ def FeatureISAVersion11_5_1 : FeatureSet<
FeatureVGPRSingleUseHintInsts,
Feature1_5xVGPRs])>;
+def FeatureISAVersion11_5_2 : FeatureSet<
shiltian wrote:
GFX1152 is same as GFX1150. In my internal PR, I took @jayfoad 's suggest
@@ -1534,6 +1534,12 @@ def FeatureISAVersion11_5_1 : FeatureSet<
FeatureVGPRSingleUseHintInsts,
Feature1_5xVGPRs])>;
+def FeatureISAVersion11_5_2 : FeatureSet<
rampitec wrote:
I don't know, but if they are I have a question why a new target needed?
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/94534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1534,6 +1534,12 @@ def FeatureISAVersion11_5_1 : FeatureSet<
FeatureVGPRSingleUseHintInsts,
Feature1_5xVGPRs])>;
+def FeatureISAVersion11_5_2 : FeatureSet<
shiltian wrote:
Are they not?
https://github.com/llvm/llvm-project/pull/94534
__
@@ -1534,6 +1534,12 @@ def FeatureISAVersion11_5_1 : FeatureSet<
FeatureVGPRSingleUseHintInsts,
Feature1_5xVGPRs])>;
+def FeatureISAVersion11_5_2 : FeatureSet<
rampitec wrote:
Looks the same as 1150?
https://github.com/llvm/llvm-project/pull/94534
https://github.com/shiltian updated
https://github.com/llvm/llvm-project/pull/94534
>From 1bdb851ff0b21e73228a2f0a6c2752c47de9dda0 Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Wed, 5 Jun 2024 16:44:09 -0400
Subject: [PATCH] [AMDGPU] Add a new target gfx1152
---
clang/include/clang/Basic/C
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Shilei Tian (shiltian)
Changes
---
Patch is 32.59 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/94534.diff
28 Files Affected:
- (modified) clang/include/clang/Basic/Cuda.h (+1)
- (
llvmbot wrote:
@llvm/pr-subscribers-offload
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-codegen
Author: Shilei Tian (shiltian)
Changes
---
Patch is 32.59 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/94534.diff
28 Files Affected:
https://github.com/shiltian created
https://github.com/llvm/llvm-project/pull/94534
None
>From cf1e045d09d18f19bef4a8eb07f86e00f3b6f7a6 Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Wed, 5 Jun 2024 16:18:57 -0400
Subject: [PATCH] [AMDGPU] Add a new target gfx1152
---
clang/include/clang/B
12 matches
Mail list logo