[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-02-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-asan` running on `sanitizer-buildbot7` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/24/builds/5252 Here is the releva

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-02-12 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/125020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-02-12 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/125020 >From 10af91096eda7eb2b7f07cf239f53ac3af456566 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 29 Jan 2025 19:59:21 -0800 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-02-12 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/125020 >From 10af91096eda7eb2b7f07cf239f53ac3af456566 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 29 Jan 2025 19:59:21 -0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-02-12 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > Please add a release note so that users know about the fix and about the > expected performance costs, but otherwise LGTM done https://github.com/llvm/llvm-project/pull/125020 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-02-12 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/125020 >From 10af91096eda7eb2b7f07cf239f53ac3af456566 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 29 Jan 2025 19:59:21 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-02-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > The public libclang interface needs to be stable, yes... but in this context, > that's just the interfaces declared in clang/include/clang-c/CXString.h. We > can do whatever we want with the internal interface in > clang/tools/libclang/CXString.h. Oh, good catch! Agreed.

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-02-11 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: The public libclang interface needs to be stable, yes... but in this context, that's just the interfaces declared in clang/include/clang-c/CXString.h. We can do whatever we want with the internal interface in clang/tools/libclang/CXString.h. https://github.com/llvm/llvm-p

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-02-10 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: If `CXString createRef(StringRef)` is essentially equivalent to `CXString createDup(StringRef)`, should we just get rid of `CXString createRef(StringRef)`? https://github.com/llvm/llvm-project/pull/125020 _

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-02-07 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: ping https://github.com/llvm/llvm-project/pull/125020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-02-03 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: ping https://github.com/llvm/llvm-project/pull/125020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-01-29 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/125020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-01-29 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/125020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang] Always Dup in createRef(StringRef) (PR #125020)

2025-01-29 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/125020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits