[clang] [libclang/python] Change all global variables to snake case (PR #132378)

https://github.com/DeinAlptraum created https://github.com/llvm/llvm-project/pull/132378 None >From 926d2f7175fa7f04eae94291742ec7c89ea18516 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Fri, 21 Mar 2025 21:03:24 +0900 Subject: [PATCH] [libclang/python] Change all global variables to sna

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

Endilll wrote: Sorry for the churn https://github.com/llvm/llvm-project/pull/132378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

Endilll wrote: I was pointed out that there is a separate rule that constants are supposed to be in `SCREAMING_CAPS` (https://peps.python.org/pep-0008/#constants). We should've changed the names (`k` prefix is out of place anyway), but not to `snake_case` as I implied. https://github.com/llvm

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

https://github.com/DeinAlptraum closed https://github.com/llvm/llvm-project/pull/132378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/132378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

@@ -10,7 +10,7 @@ import sys from pathlib import Path -kInputsDir = os.path.join(os.path.dirname(__file__), "INPUTS") +k_inputs_dir = os.path.join(os.path.dirname(__file__), "INPUTS") Endilll wrote: "Konstant", I guess https://github.com/llvm/llvm-project/pu

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

@@ -10,7 +10,7 @@ import sys from pathlib import Path -kInputsDir = os.path.join(os.path.dirname(__file__), "INPUTS") +k_inputs_dir = os.path.join(os.path.dirname(__file__), "INPUTS") DeinAlptraum wrote: Sounds good. I've been wondering the entire time what t

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

@@ -10,7 +10,7 @@ import sys from pathlib import Path -kInputsDir = os.path.join(os.path.dirname(__file__), "INPUTS") +k_inputs_dir = os.path.join(os.path.dirname(__file__), "INPUTS") Endilll wrote: Can you also drop `k_` prefix? According to PEP 8, naming co

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/132378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/132378 >From 926d2f7175fa7f04eae94291742ec7c89ea18516 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Fri, 21 Mar 2025 21:03:24 +0900 Subject: [PATCH 1/2] [libclang/python] Change all global variables to snake

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

https://github.com/Endilll commented: LGTM otherwise https://github.com/llvm/llvm-project/pull/132378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Change all global variables to snake case (PR #132378)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Jannick Kremer (DeinAlptraum) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/132378.diff 7 Files Affected: - (modified) clang/bindings/python/clang/cindex.py (+5-5) - (modified) clang/bindings/python/tests/cindex/tes