[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum closed https://github.com/llvm/llvm-project/pull/138132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/138132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Jannick Kremer via cfe-commits
@@ -16,6 +16,8 @@ from .util import get_cursor, get_tu +INPUTS_DIR = os.path.join(os.path.dirname(__file__), "INPUTS") DeinAlptraum wrote: Yes, I changed these to use `pathlib.Path` instead https://github.com/llvm/llvm-project/pull/138132 __

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/138132 >From 74cf17d76918c465aa24e391e15546ab030483f2 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Thu, 1 May 2025 22:42:56 +0900 Subject: [PATCH 1/2] [libclang/python] Add tests for equality operators. Ad

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
@@ -16,6 +16,8 @@ from .util import get_cursor, get_tu +INPUTS_DIR = os.path.join(os.path.dirname(__file__), "INPUTS") Endilll wrote: I think our minimal requirements for Python version allow us to take advantage of `pathlib`. https://github.com/llvm/llvm-

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: @Endilll Thank you, I put the removal of the compatibility stuff in a separate PR here: https://github.com/llvm/llvm-project/pull/138135 https://github.com/llvm/llvm-project/pull/138132 ___ cfe-commits mailing list cfe-commits@list

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > @Endilll I added the tests as discussed on #138074 . Thank you! > I'm just not sure how/if we can reasonably test the `else` path for > `briefComment`: this requires a `libclang.so` built before LLVM 3.2 (the > check was added 13 years ago in > [b947e82](https://github.com/l

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: @Endilll I added the tests as discussed on #138074 . I'm just not sure how/if we can reasonably test the `else` path for `briefComment`: this requires a libclang.so built before LLVM 3.2. In fact, I'm not entirely sure what the point here is: being able to use the same `lib

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jannick Kremer (DeinAlptraum) Changes Adds tests for SourceRange, SourceLocation and Cursor. This is a follow-up to #138074 --- Full diff: https://github.com/llvm/llvm-project/pull/138132.diff 3 Files Affected: - (modified) clang/bindin

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum created https://github.com/llvm/llvm-project/pull/138132 Adds tests for SourceRange, SourceLocation and Cursor. This is a follow-up to #138074 >From 74cf17d76918c465aa24e391e15546ab030483f2 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Thu, 1 May 2025 22:4