efriedma-quic wrote:
The PrintingPolicy constants just reflect the names from
clang/include/clang/AST/PrettyPrinter.h. For FullyQualifiedName specifically:
> /// When true, print the fully qualified name of function declarations.
> /// This is the opposite of SuppressScope and thus overrules
epistax wrote:
Should this have enabled getting fully qualified type names? From Python I am
using a PrintingPolicy with the FullyQualifiedName property set, but using
pretty_printed on a type name with the policy does not provide a fully
qualified name.
https://github.com/llvm/llvm-project/
https://github.com/efriedma-quic closed
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
Oh, looks like that fixed it, thanks.
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
The failure reminds me of #122063, which was merged just 2 hours ago.
Do you mind merging the `main` into your PR and try again?
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
efriedma-quic wrote:
Still failing the same way.
Should I go ahead and merge anyway, or is there someone who can look into this?
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
https://github.com/efriedma-quic updated
https://github.com/llvm/llvm-project/pull/120494
>From 13a9c0b88afae7a5f48a66e86357f7284fdace95 Mon Sep 17 00:00:00 2001
From: Eli Friedman
Date: Tue, 17 Dec 2024 15:25:00 -0800
Subject: [PATCH] [libclang/python] Add python bindings for PrintingPolicy
T
DeinAlptraum wrote:
@efriedma-quic no idea, I would just rebase and hope that's it
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
@DeinAlptraum any idea why the Python tests are failing?
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic updated
https://github.com/llvm/llvm-project/pull/120494
>From 13a9c0b88afae7a5f48a66e86357f7284fdace95 Mon Sep 17 00:00:00 2001
From: Eli Friedman
Date: Tue, 17 Dec 2024 15:25:00 -0800
Subject: [PATCH] [libclang/python] Add python bindings for PrintingPolicy
T
https://github.com/DeinAlptraum approved this pull request.
LGTM! @Endilll did you want to take a look at this as well?
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/efriedma-quic updated
https://github.com/llvm/llvm-project/pull/120494
>From 13a9c0b88afae7a5f48a66e86357f7284fdace95 Mon Sep 17 00:00:00 2001
From: Eli Friedman
Date: Tue, 17 Dec 2024 15:25:00 -0800
Subject: [PATCH] [libclang/python] Add python bindings for PrintingPolicy
T
https://github.com/efriedma-quic edited
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic updated
https://github.com/llvm/llvm-project/pull/120494
>From 4de2bf3b617538fbc299d5f84d8a8e17d3ff5072 Mon Sep 17 00:00:00 2001
From: Eli Friedman
Date: Tue, 17 Dec 2024 15:25:00 -0800
Subject: [PATCH] [libclang/python] Add python bindings for PrintingPolicy
T
@@ -981,3 +983,13 @@ def test_from_result_null(self):
def test_from_cursor_result_null(self):
tu = get_tu("")
self.assertEqual(tu.cursor.semantic_parent, None)
+
+def test_pretty_print(self):
+tu = get_tu("struct X { int x; }; void f(bool x) { }"
@@ -3685,6 +3695,71 @@ def write_main_file_to_stdout(self):
conf.lib.clang_CXRewriter_writeMainFileToStdOut(self)
+class PrintingPolicyProperty(BaseEnumeration):
+
+"""
+A PrintingPolicyProperty identifies a property of a PrintingPolicy.
+"""
+Indentat
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum commented:
Thanks for the PR! Two minor comments and formatting, otherwise LGTM!
https://github.com/llvm/llvm-project/pull/120494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/efriedma-quic updated
https://github.com/llvm/llvm-project/pull/120494
>From ec604efdae3e05bf14ade994cbc7d0f1acebd1c6 Mon Sep 17 00:00:00 2001
From: Eli Friedman
Date: Tue, 17 Dec 2024 15:25:00 -0800
Subject: [PATCH] [libclang/python] Add python bindings for PrintingPolicy
-
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
07e053fb95e131244dafab04aae84650de383664...8f2e784333ed7cdd746dd408b18c2f12297378fe
clang
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Eli Friedman (efriedma-quic)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/120494.diff
2 Files Affected:
- (modified) clang/bindings/python/clang/cindex.py (+78)
- (modified) clang/bindings/python/tests/cindex/test_
https://github.com/efriedma-quic created
https://github.com/llvm/llvm-project/pull/120494
None
>From 8f2e784333ed7cdd746dd408b18c2f12297378fe Mon Sep 17 00:00:00 2001
From: Eli Friedman
Date: Tue, 17 Dec 2024 15:25:00 -0800
Subject: [PATCH] [libclang/python] Add python bindings for PrintingPol
22 matches
Mail list logo
