[clang] [libc] Fix printf config not working (PR #66834)

2023-09-20 Thread Siva Chandra via cfe-commits
@@ -112,6 +112,16 @@ add_libc_unittest( LibcMemoryHelpers ) +if(LIBC_CONF_PRINTF_DISABLE_FLOAT) sivachandra wrote: I do not think this pattern is how the copts are to be used. In this particular case, I think the right way would be to split `sprintf_test

[clang] [libc] Fix printf config not working (PR #66834)

2023-09-19 Thread via cfe-commits
https://github.com/michaelrj-google closed https://github.com/llvm/llvm-project/pull/66834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Fix printf config not working (PR #66834)

2023-09-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/66834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Fix printf config not working (PR #66834)

2023-09-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libc Changes The list of printf copts available in config.json wasn't working because the printf_core subdirectory was included before the printf_copts variable was defined, making it effectively nothing for the printf internals. Additionally, the tests w