[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-17 Thread David Truby via cfe-commits
https://github.com/DavidTruby closed https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-17 Thread David Truby via cfe-commits
DavidTruby wrote: Linux builds appear to have stopped, but all the previous linux builds worked so I think this is fine to merge. I will revert if it breaks post-commit. https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-17 Thread David Truby via cfe-commits
https://github.com/DavidTruby updated https://github.com/llvm/llvm-project/pull/99058 >From 66e13f92a0680742b552fabde25df7752f8510c9 Mon Sep 17 00:00:00 2001 From: David Truby Date: Tue, 16 Jul 2024 15:39:28 + Subject: [PATCH 1/3] [flang] Add -rtlib flag This patch allows the -rtlib flag w

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread Carlos Seo via cfe-commits
https://github.com/ceseo approved this pull request. Yes, this should be enough. https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread David Truby via cfe-commits
DavidTruby wrote: It looks like clang_rt.crtbegin and clang_rt.crtend aren't always used on every platform so I've just removed the check for those. The check for `libclang_rt.builtins` and NOT `libgcc` and `libgcc_s` should be enough to check we are linking the right thing. https://github.co

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread David Truby via cfe-commits
https://github.com/DavidTruby updated https://github.com/llvm/llvm-project/pull/99058 >From 66e13f92a0680742b552fabde25df7752f8510c9 Mon Sep 17 00:00:00 2001 From: David Truby Date: Tue, 16 Jul 2024 15:39:28 + Subject: [PATCH 1/2] [flang] Add -rtlib flag This patch allows the -rtlib flag w

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread Kelvin Li via cfe-commits
kkwli wrote: The linker-flags test fails on AIX too. https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread Carlos Seo via cfe-commits
https://github.com/ceseo commented: linker-flags test seems to be failing on Windows. https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread Carlos Seo via cfe-commits
ceseo wrote: > I don't know why the pre-commit build failed on Windows. The build itself > looks fine but seems to be complaining about slow tests? Actually, the error is here: ``` FAIL: Flang :: Driver/linker-flags.f90 (218 of 2807) TEST 'Flang :: Driver/linker-flags.f90'

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread David Truby via cfe-commits
DavidTruby wrote: I don't know why the pre-commit build failed on Windows. The build itself looks fine but seems to be complaining about slow tests? https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread Andrzej WarzyƄski via cfe-commits
https://github.com/banach-space approved this pull request. https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread Tom Eccles via cfe-commits
https://github.com/tblah approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-flang-driver Author: David Truby (DavidTruby) Changes This patch allows the -rtlib flag with flang-new to select between the libgcc_s and compiler-rt runtimes. The behaviour is identical to the same flag with clang. --- Full

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread David Truby via cfe-commits
https://github.com/DavidTruby created https://github.com/llvm/llvm-project/pull/99058 This patch allows the -rtlib flag with flang-new to select between the libgcc_s and compiler-rt runtimes. The behaviour is identical to the same flag with clang. >From 66e13f92a0680742b552fabde25df7752f8510c9