[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

kiranchandramohan wrote: This patch might partially address the issue raised in https://github.com/llvm/llvm-project/issues/73180 https://github.com/llvm/llvm-project/pull/132801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

mrkajetanp wrote: > This patch might partially address the issue raised in > https://github.com/llvm/llvm-project/issues/73180 Certainly, I tracked a regression in a workload down to flang not running the slp vectorizer. Hence this patch. https://github.com/llvm/llvm-project/pull/132801 _

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

mrkajetanp wrote: The buildbot failure fix is here: https://github.com/llvm/llvm-project/pull/133128 https://github.com/llvm/llvm-project/pull/132801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

mrkajetanp wrote: > Is this buildbot failure related: > [https://lab.llvm.org/buildbot/#/builders/89/builds/19482](https://lab.llvm.org/buildbot/#/builders/89/builds/19482)? Ah yes, sorry about that! Just a missing -o /dev/null, I'll post a fix in a moment. https://github.com/llvm/llvm-proje

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

kiranchandramohan wrote: > Is this buildbot failure related: > https://lab.llvm.org/buildbot/#/builders/89/builds/19482? Likely. We shouldn't be generating files in driver tests. For checking output, we have to pipe the output to FileCheck. https://github.com/llvm/llvm-project/pull/132801 ___

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

tarunprabhu wrote: Is this buildbot failure related: [https://lab.llvm.org/buildbot/#/builders/89/builds/19482](https://lab.llvm.org/buildbot/#/builders/89/builds/19482)? https://github.com/llvm/llvm-project/pull/132801 ___ cfe-commits mailing list cf

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/132801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/DavidTruby approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/132801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

mrkajetanp wrote: > Apart from the docstrings, this looks good. Thanks for the changes :-) Done, thanks a lot for the review! :) https://github.com/llvm/llvm-project/pull/132801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/mrkajetanp updated https://github.com/llvm/llvm-project/pull/132801 >From d9b2a86d01688b69b8f116f6b52caeec8cd6e756 Mon Sep 17 00:00:00 2001 From: Kajetan Puchalski Date: Mon, 24 Mar 2025 17:28:03 + Subject: [PATCH 1/5] [flang] Add -f[no-]slp-vectorize flags Add -f[no-]sl

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

@@ -3177,3 +3177,25 @@ bool tools::shouldEnableVectorizerAtOLevel(const ArgList &Args, bool isSlpVec) { return false; } + +/// Enable -fvectorize based on the optimization level selected. tarunprabhu wrote: It might be better to move the docstrings to `Com

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

@@ -3177,3 +3177,25 @@ bool tools::shouldEnableVectorizerAtOLevel(const ArgList &Args, bool isSlpVec) { return false; } + +/// Enable -fvectorize based on the optimization level selected. +void tools::handleVectorizeLoopsArgs(const ArgList &Args, +

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/tarunprabhu edited https://github.com/llvm/llvm-project/pull/132801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/tarunprabhu approved this pull request. Apart from the docstrings, this looks good. Thanks for the changes :-) https://github.com/llvm/llvm-project/pull/132801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

@@ -1,10 +1,15 @@ ! RUN: %flang -### -S -fslp-vectorize %s 2>&1 | FileCheck -check-prefix=CHECK-SLP-VECTORIZE %s ! RUN: %flang -### -S -fno-slp-vectorize %s 2>&1 | FileCheck -check-prefix=CHECK-NO-SLP-VECTORIZE %s +! RUN: %flang -### -S -O0 %s 2>&1 | FileCheck -check-prefix=C

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/mrkajetanp updated https://github.com/llvm/llvm-project/pull/132801 >From d9b2a86d01688b69b8f116f6b52caeec8cd6e756 Mon Sep 17 00:00:00 2001 From: Kajetan Puchalski Date: Mon, 24 Mar 2025 17:28:03 + Subject: [PATCH 1/4] [flang] Add -f[no-]slp-vectorize flags Add -f[no-]sl

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

@@ -1,10 +1,15 @@ ! RUN: %flang -### -S -fslp-vectorize %s 2>&1 | FileCheck -check-prefix=CHECK-SLP-VECTORIZE %s ! RUN: %flang -### -S -fno-slp-vectorize %s 2>&1 | FileCheck -check-prefix=CHECK-NO-SLP-VECTORIZE %s +! RUN: %flang -### -S -O0 %s 2>&1 | FileCheck -check-prefix=C

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/mrkajetanp updated https://github.com/llvm/llvm-project/pull/132801 >From d9b2a86d01688b69b8f116f6b52caeec8cd6e756 Mon Sep 17 00:00:00 2001 From: Kajetan Puchalski Date: Mon, 24 Mar 2025 17:28:03 + Subject: [PATCH 1/3] [flang] Add -f[no-]slp-vectorize flags Add -f[no-]sl

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/mrkajetanp updated https://github.com/llvm/llvm-project/pull/132801 >From d9b2a86d01688b69b8f116f6b52caeec8cd6e756 Mon Sep 17 00:00:00 2001 From: Kajetan Puchalski Date: Mon, 24 Mar 2025 17:28:03 + Subject: [PATCH 1/3] [flang] Add -f[no-]slp-vectorize flags Add -f[no-]sl

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/mrkajetanp updated https://github.com/llvm/llvm-project/pull/132801 >From d9b2a86d01688b69b8f116f6b52caeec8cd6e756 Mon Sep 17 00:00:00 2001 From: Kajetan Puchalski Date: Mon, 24 Mar 2025 17:28:03 + Subject: [PATCH 1/4] [flang] Add -f[no-]slp-vectorize flags Add -f[no-]sl

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

@@ -3177,3 +3177,25 @@ bool tools::shouldEnableVectorizerAtOLevel(const ArgList &Args, bool isSlpVec) { return false; } + +/// Enable -fvectorize based on the optimization level selected. +void tools::handleVectorizeLoopsArgs(const ArgList &Args, +

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/mrkajetanp updated https://github.com/llvm/llvm-project/pull/132801 >From d9b2a86d01688b69b8f116f6b52caeec8cd6e756 Mon Sep 17 00:00:00 2001 From: Kajetan Puchalski Date: Mon, 24 Mar 2025 17:28:03 + Subject: [PATCH 1/2] [flang] Add -f[no-]slp-vectorize flags Add -f[no-]sl

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/mrkajetanp updated https://github.com/llvm/llvm-project/pull/132801 >From d9b2a86d01688b69b8f116f6b52caeec8cd6e756 Mon Sep 17 00:00:00 2001 From: Kajetan Puchalski Date: Mon, 24 Mar 2025 17:28:03 + Subject: [PATCH 1/2] [flang] Add -f[no-]slp-vectorize flags Add -f[no-]sl

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

tarunprabhu wrote: > cc @tblah @DavidTruby If you are soliciting reviews, you could also use the "Reviewers" box on the top right of this page https://github.com/llvm/llvm-project/pull/132801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

tarunprabhu wrote: > > If you are soliciting reviews, you could also use the "Reviewers" box on > > the top right of this page > > I would, but I do not currently have the right permissions to use the box. > Hence the ccs - I need someone else to do it. Huh. I didn't realize that one needed s

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

mrkajetanp wrote: > If you are soliciting reviews, you could also use the "Reviewers" box on the > top right of this page I would, but I do not currently have the right permissions to use the box. Hence the ccs - I need someone else to do it. https://github.com/llvm/llvm-project/pull/132801

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

@@ -0,0 +1,10 @@ +! RUN: %flang -### -S -fslp-vectorize %s 2>&1 | FileCheck -check-prefix=CHECK-SLP-VECTORIZE %s +! RUN: %flang -### -S -fno-slp-vectorize %s 2>&1 | FileCheck -check-prefix=CHECK-NO-SLP-VECTORIZE %s +! RUN: %flang -### -S -O1 %s 2>&1 | FileCheck -check-prefix=CH

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/tarunprabhu requested changes to this pull request. https://github.com/llvm/llvm-project/pull/132801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

@@ -4032,11 +4032,14 @@ def : Flag<["-"], "ftree-vectorize">, Alias; def : Flag<["-"], "fno-tree-vectorize">, Alias; } +let Visibility = [ClangOption, FlangOption] in { tarunprabhu wrote: I think we should merge this with the visibility block for `fvectorize`

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

@@ -161,6 +161,14 @@ void Flang::addCodegenOptions(const ArgList &Args, options::OPT_fno_vectorize, enableVec)) CmdArgs.push_back("-vectorize-loops"); + // -fslp-vectorize is enabled based on the optimization level selected. + bool EnableSLPVec = shoul

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

@@ -0,0 +1,10 @@ +! RUN: %flang -### -S -fslp-vectorize %s 2>&1 | FileCheck -check-prefix=CHECK-SLP-VECTORIZE %s +! RUN: %flang -### -S -fno-slp-vectorize %s 2>&1 | FileCheck -check-prefix=CHECK-NO-SLP-VECTORIZE %s +! RUN: %flang -### -S -O1 %s 2>&1 | FileCheck -check-prefix=CH

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Kajetan Puchalski (mrkajetanp) Changes Add -f[no-]slp-vectorize to the flang driver. Add corresponding -fvectorize-slp to the flang frontend. --- Full diff: https://github.com/llvm/llvm-project/pull/132801.diff 6 Files Affected:

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

mrkajetanp wrote: cc @tblah @DavidTruby https://github.com/llvm/llvm-project/pull/132801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -f[no-]slp-vectorize flags (PR #132801)

https://github.com/mrkajetanp created https://github.com/llvm/llvm-project/pull/132801 Add -f[no-]slp-vectorize to the flang driver. Add corresponding -fvectorize-slp to the flang frontend. >From d9b2a86d01688b69b8f116f6b52caeec8cd6e756 Mon Sep 17 00:00:00 2001 From: Kajetan Puchalski Date: Mo