https://github.com/kiranchandramohan closed
https://github.com/llvm/llvm-project/pull/90420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kiranchandramohan updated
https://github.com/llvm/llvm-project/pull/90420
>From 78e91d2d84638ded51267c5e0720cc1d1d4d773b Mon Sep 17 00:00:00 2001
From: Kiran Chandramohan
Date: Fri, 26 Apr 2024 09:26:11 +
Subject: [PATCH 1/2] [Flang][Driver] Add support for -w option 1/n
kiranchandramohan wrote:
Done.
https://github.com/llvm/llvm-project/pull/90420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kiranchandramohan updated
https://github.com/llvm/llvm-project/pull/90420
>From 78e91d2d84638ded51267c5e0720cc1d1d4d773b Mon Sep 17 00:00:00 2001
From: Kiran Chandramohan
Date: Fri, 26 Apr 2024 09:26:11 +
Subject: [PATCH 1/2] [Flang][Driver] Add support for -w option 1/n
banach-space wrote:
[nit] Once you have more than one prefix, `CHECK` becomes noise. At least IMHO
đ
(we all know that these are "check" lines). You could use more descriptive
prefixes instead, e.g. `CHECK-PORT` -> `PORTABILITY` (it wasn't obvious to me
that
https://github.com/banach-space approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/90420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/banach-space edited
https://github.com/llvm/llvm-project/pull/90420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kiranchandramohan edited
https://github.com/llvm/llvm-project/pull/90420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
