iseki0 wrote:
> I'll go ahead and merge the change on your behalf as I suspect that you do
> not have commit rights as this is your first PR to the project. Thank you for
> the contribution!
Thank you
https://github.com/llvm/llvm-project/pull/119090
___
github-actions[bot] wrote:
@iseki0 Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build,
https://github.com/compnerd closed
https://github.com/llvm/llvm-project/pull/119090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd wrote:
I'll go ahead and merge the change on your behalf as I suspect that you do not
have commit rights as this is your first PR to the project. Thank you for the
contribution!
https://github.com/llvm/llvm-project/pull/119090
___
cfe-commit
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/119090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/iseki0 updated
https://github.com/llvm/llvm-project/pull/119090
>From 06be29809a8ac03e4ec9546e1dcfc138ab79167b Mon Sep 17 00:00:00 2001
From: iseki zero
Date: Sun, 8 Dec 2024 03:17:40 +0800
Subject: [PATCH 1/2] [docs] Add a more detailed description in CXString.h.
---
clang
@@ -46,6 +46,9 @@ typedef struct {
/**
* Retrieve the character data associated with the given string.
+ *
+ * The caller shouldn't free the returned string data, and the returned string
+ * data shouldn't be accessed after the \c CXString disposed.
iseki0 wr
@@ -46,6 +46,9 @@ typedef struct {
/**
* Retrieve the character data associated with the given string.
+ *
+ * The caller shouldn't free the returned string data, and the returned string
+ * data shouldn't be accessed after the \c CXString disposed.
compnerd
@@ -46,6 +46,9 @@ typedef struct {
/**
* Retrieve the character data associated with the given string.
+ *
+ * The caller shouldn't free the returned string data, and the returned string
+ * data shouldn't be accessed after the \c CXString disposed.
iseki0 wr
@@ -46,6 +46,9 @@ typedef struct {
/**
* Retrieve the character data associated with the given string.
+ *
+ * The caller shouldn't free the returned string data, and the returned string
+ * data shouldn't be accessed after the \c CXString disposed.
compnerd
https://github.com/compnerd edited
https://github.com/llvm/llvm-project/pull/119090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -46,6 +46,9 @@ typedef struct {
/**
* Retrieve the character data associated with the given string.
+ *
+ * The caller shouldn't free the returned string data, and the returned string
+ * data shouldn't be accessed after the \c CXString disposed.
iseki0 wr
@@ -46,6 +46,9 @@ typedef struct {
/**
* Retrieve the character data associated with the given string.
+ *
+ * The caller shouldn't free the returned string data, and the returned string
+ * data shouldn't be accessed after the \c CXString disposed.
compnerd
https://github.com/iseki0 created
https://github.com/llvm/llvm-project/pull/119090
Emmm... Maybe I'm splitting hairs. But I really think the paragraph should be
more detailed. The orginal document makes me confused. Do I take the ownership
of the string data?
Here I don't refer the `clang_dis
iseki0 wrote:
@egorzhdan @compnerd
Thank you.
https://github.com/llvm/llvm-project/pull/119090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: iseki (iseki0)
Changes
Emmm... Maybe I'm splitting hairs. But I really think the paragraph should be
more detailed. The orginal document makes me confused. Do I take the ownership
of the string data?
Here I don't refer the `clang_dispose
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
17 matches
Mail list logo
