[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/ChuanqiXu9 approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/78589 >From 07c6ad92fda63e69489933b5cededf8f03a68ef3 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Jan 2024 14:38:22 + Subject: [PATCH 1/6] [coroutine] Create coroutine body in the correct eval context

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

@@ -0,0 +1,34 @@ +// RUN: %clang_cc1 -std=c++20 -ast-dump %s | FileCheck %s +#include "Inputs/std-coroutine.h" + +// Github issue: https://github.com/llvm/llvm-project/issues/78290 +class Gen { + public: +class promise_type { + public: +template +explic

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

@@ -0,0 +1,34 @@ +// RUN: %clang_cc1 -std=c++20 -ast-dump %s | FileCheck %s +#include "Inputs/std-coroutine.h" + +// Github issue: https://github.com/llvm/llvm-project/issues/78290 hokein wrote: nit: we usually encode the github issue with `namespace GH78290 {...

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/hokein approved this pull request. thanks, this looks good to me. https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/78589 >From 07c6ad92fda63e69489933b5cededf8f03a68ef3 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Jan 2024 14:38:22 + Subject: [PATCH 1/5] [coroutine] Create coroutine body in the correct eval context

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

@@ -804,6 +804,9 @@ Bug Fixes in This Version Objective-C++ property accesses to not be converted to a function call to the getter in the placement-args of new-expressions. Fixes (`#65053 `_) +- Fix an issue with missing

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/cor3ntin approved this pull request. LGTM, thanks! Please give a chance to @ChuanqiXu9 to look at it before merging https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

usx95 wrote: Added release notes and fix new line. https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/78589 >From 07c6ad92fda63e69489933b5cededf8f03a68ef3 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Jan 2024 14:38:22 + Subject: [PATCH 1/4] [coroutine] Create coroutine body in the correct eval context

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/78589 >From 07c6ad92fda63e69489933b5cededf8f03a68ef3 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Jan 2024 14:38:22 + Subject: [PATCH 1/3] [coroutine] Create coroutine body in the correct eval context

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/cor3ntin commented: Can you add a release note for this change (mentioning the issue) ? thanks! https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

@@ -0,0 +1,34 @@ +// RUN: %clang_cc1 -std=c++20 -ast-dump %s | FileCheck %s +#include "Inputs/std-coroutine.h" + +// Github issue: https://github.com/llvm/llvm-project/issues/78290 +class Gen { + public: +class promise_type { + public: +template +explic

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/78589 >From 07c6ad92fda63e69489933b5cededf8f03a68ef3 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Thu, 18 Jan 2024 14:38:22 + Subject: [PATCH 1/2] [coroutine] Create coroutine body in the correct eval context

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

llvmbot wrote: @llvm/pr-subscribers-coroutines Author: Utkarsh Saxena (usx95) Changes Fixes: https://github.com/llvm/llvm-project/issues/78290 See the bug for more context. ``` Gen ACoroutine() { if constexpr (0) // remove it make clang compile. co_return; co_await Gen{}; } ``` We

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/78589 Fixes: https://github.com/llvm/llvm-project/issues/78290 See the bug for more context. ``` Gen ACoroutine() { if constexpr (0) // remove it make clang compile. co_return; co_await Gen{}; } ``` We miss symbol