[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread LLVM Continuous Integration via cfe-commits
Martin =?utf-8?q?Storsjö?= Message-ID: In-Reply-To: llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-solaris11-sparcv9` running on `solaris11-sparcv9` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/bu

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/108539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/108539 From 4119204e2da13d00bd6ac5d23e05a4f269b2b75c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Fri, 13 Sep 2024 13:57:49 +0300 Subject: [PATCH 1/2] [clang-scan-deps] Infer the tool locatio

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. https://github.com/llvm/llvm-project/pull/108539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Ok, thanks for the explanation. This LGTM, but the checks are failing on > Windows due to `.exe` extension that's not accounted for. I don't think any > of the tests you touched really care about the executable path, so I'd be > fine with just removing those check lines. Ah,

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: And practically - in the cases I've seen where CMake generates calls to `clang-scan-deps`, it always invokes `clang-scan-deps ... -- /absolute/path/to/compiler` (CMake in general is very keen on absolute paths to tools). But in separate testing of these tools, I ran into this

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Can you explain why exactly is this necessary/beneficial? If the compilation > database got created with just the tool name, I'd expect the rest of the > build to be able to use just the tool name when the scanner spits it out > again, no? If this is about the scanner finding

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Can you explain why exactly is this necessary/beneficial? If the compilation database got created with just the tool name, I'd expect the rest of the build to be able to use just the tool name when the scanner spits it out again, no? If this is about the scanner finding the

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Martin Storsjö (mstorsjo) Changes This allows the clang driver to know which tool is meant to be executed, which allows the clang driver to load the right clang config files, and allows clang to find colocated sysroots. This makes sure t

[clang] [clang-scan-deps] Infer the tool locations from PATH (PR #108539)

2024-09-13 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/108539 This allows the clang driver to know which tool is meant to be executed, which allows the clang driver to load the right clang config files, and allows clang to find colocated sysroots. This makes sure that d