https://github.com/hahnjo closed
https://github.com/llvm/llvm-project/pull/103028
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev approved this pull request.
Lgtm!
https://github.com/llvm/llvm-project/pull/103028
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
> > > BTW, the delayed template parsing is a deprecated technique. Both clang
> > > and MSVC won't enable this after C++20 and we think it is the root of
> > > many bugs.
> >
> >
> > I agree. It was needed in the past to parse the MSVC stdlib, let's check if
> > we still ne
hahnjo wrote:
> > BTW, the delayed template parsing is a deprecated technique. Both clang and
> > MSVC won't enable this after C++20 and we think it is the root of many bugs.
>
> I agree. It was needed in the past to parse the MSVC stdlib, let's check if
> we still need it:
> [root-project/ro
https://github.com/ChuanqiXu9 approved this pull request.
Looks not bad. Let's land it after the CI gets green.
BTW, the delayed template parsing is a deprecated technique. Both clang and
MSVC won't enable this after C++20 and we think it is the root of many bugs.
https://github.com/llvm/llvm-
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jonas Hahnfeld (hahnjo)
Changes
When instantiating a delayed template, the recorded token stream is passed to
`Parser::ParseLateTemplatedFuncDef` which will append the current token "so it
doesn't get lost". With incremental extensions en
https://github.com/hahnjo created
https://github.com/llvm/llvm-project/pull/103028
When instantiating a delayed template, the recorded token stream is passed to
`Parser::ParseLateTemplatedFuncDef` which will append the current token "so it
doesn't get lost". With incremental extensions enabled
