llvmbot wrote:
/pull-request llvm/llvm-project#105773
https://github.com/llvm/llvm-project/pull/105043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
/cherry-pick 714033a6bf3a81b1350f969ddd83bcd9fbb703e8
https://github.com/llvm/llvm-project/pull/105043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/105043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/105043
>From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 20 Aug 2024 06:44:41 -0700
Subject: [PATCH 1/6] [clang-format] Don't insert a space between :: and *
Also, don't
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/105043
>From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 20 Aug 2024 06:44:41 -0700
Subject: [PATCH 1/5] [clang-format] Don't insert a space between :: and *
Also, don't
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/105043
>From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 20 Aug 2024 06:44:41 -0700
Subject: [PATCH 1/4] [clang-format] Don't insert a space between :: and *
Also, don't
@@ -4589,9 +4589,12 @@ bool TokenAnnotator::spaceRequiredBetween(const
AnnotatedLine &Line,
if (!BeforeLeft)
return false;
if (BeforeLeft->is(tok::coloncolon)) {
- const auto *Prev = BeforeLeft->Previous;
- return Left.is(tok::star) && Prev &&
-
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/105043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4589,9 +4589,12 @@ bool TokenAnnotator::spaceRequiredBetween(const
AnnotatedLine &Line,
if (!BeforeLeft)
return false;
if (BeforeLeft->is(tok::coloncolon)) {
- const auto *Prev = BeforeLeft->Previous;
- return Left.is(tok::star) && Prev &&
-
https://github.com/kadircet approved this pull request.
thanks a lot!
https://github.com/llvm/llvm-project/pull/105043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/105043
>From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 20 Aug 2024 06:44:41 -0700
Subject: [PATCH 1/3] [clang-format] Don't insert a space between :: and *
Also, don't
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/105043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4591,7 +4589,9 @@ bool TokenAnnotator::spaceRequiredBetween(const
AnnotatedLine &Line,
if (!BeforeLeft)
return false;
if (BeforeLeft->is(tok::coloncolon)) {
- return Left.is(tok::star) &&
+ const auto *Prev = BeforeLeft->Previous;
+ return Left
@@ -4591,7 +4589,9 @@ bool TokenAnnotator::spaceRequiredBetween(const
AnnotatedLine &Line,
if (!BeforeLeft)
return false;
if (BeforeLeft->is(tok::coloncolon)) {
- return Left.is(tok::star) &&
+ const auto *Prev = BeforeLeft->Previous;
+ return Left
@@ -4591,7 +4589,9 @@ bool TokenAnnotator::spaceRequiredBetween(const
AnnotatedLine &Line,
if (!BeforeLeft)
return false;
if (BeforeLeft->is(tok::coloncolon)) {
- return Left.is(tok::star) &&
+ const auto *Prev = BeforeLeft->Previous;
+ return Left
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/105043
>From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 20 Aug 2024 06:44:41 -0700
Subject: [PATCH 1/2] [clang-format] Don't insert a space between :: and *
Also, don't
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/105043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4591,7 +4589,9 @@ bool TokenAnnotator::spaceRequiredBetween(const
AnnotatedLine &Line,
if (!BeforeLeft)
return false;
if (BeforeLeft->is(tok::coloncolon)) {
- return Left.is(tok::star) &&
+ const auto *Prev = BeforeLeft->Previous;
+ return Left
@@ -4591,7 +4589,9 @@ bool TokenAnnotator::spaceRequiredBetween(const
AnnotatedLine &Line,
if (!BeforeLeft)
return false;
if (BeforeLeft->is(tok::coloncolon)) {
- return Left.is(tok::star) &&
+ const auto *Prev = BeforeLeft->Previous;
+ return Left
https://github.com/kadircet requested changes to this pull request.
thanks a lot for the quick fix!
https://github.com/llvm/llvm-project/pull/105043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/105043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Also, don't insert a space after ::* for method pointers.
See https://github.com/llvm/llvm-project/pull/86253#issuecomment-2298404887.
Fixes #100841.
---
Full diff: https://github.com/llvm/llvm-project/pu
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/105043
Also, don't insert a space after ::* for method pointers.
See https://github.com/llvm/llvm-project/pull/86253#issuecomment-2298404887.
Fixes #100841.
>From 4aa47d190a84ecd0432dc9b6db1d38b296f4df23 Mon Sep 17 00
23 matches
Mail list logo
