[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-15 Thread via cfe-commits
https://github.com/eywdck2l closed https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-15 Thread via cfe-commits
https://github.com/sstwcw updated https://github.com/llvm/llvm-project/pull/66372 >From a736d84df61e3e7c1a4c8b22c7cd1e7524499d64 Mon Sep 17 00:00:00 2001 From: sstwcw Date: Thu, 14 Sep 2023 13:04:56 + Subject: [PATCH 1/2] [clang-format] Disable string breaking in JS for now See the discuss

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread Owen Pan via cfe-commits
@@ -2237,15 +2237,10 @@ ContinuationIndenter::createBreakableToken(const FormatToken &Current, LineState &State, bool AllowBreak) { unsigned StartColumn = State.Column - Current.ColumnWidth; if (Current.isStringLiteral()) { -/

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread Owen Pan via cfe-commits
@@ -2783,17 +2783,17 @@ the configuration (without a prefix: ``Auto``). const char* x = "veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; - In C#, Java, and JavaScript: + In C# and Java: .. code-block:: c++ true: - var x = "veryVery

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread via cfe-commits
https://github.com/alexfh approved this pull request. This is the right call for now. There are multiple contexts in JS, TS and libraries like Closure, where simple string literals are expected. Getting all of these right may require some back-and-forths, during which clang-format will continu

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Changes See the discussion [here](https://github.com/llvm/llvm-project/pull/66168#issuecomment-1719038797). The functionality is not mature enough. -- Full diff: https://github.com/llvm/llvm-project/pull/66372.diff 4 Files Affect

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable string breaking in JS for now (PR #66372)

2023-09-14 Thread via cfe-commits
https://github.com/sstwcw created https://github.com/llvm/llvm-project/pull/66372: See the discussion [here](https://github.com/llvm/llvm-project/pull/66168#issuecomment-1719038797). The functionality is not mature enough. >From a736d84df61e3e7c1a4c8b22c7cd1e7524499d64 Mon Sep 17 00:00:00 2001