erichkeane wrote:
> We can do a back port once the patch is settled, and it could wait until 20.2.
Based on the size/impact here, I'd be pretty against backporting this. The
regression stinks, but I'm not comfortable approving this for backport.
https://github.com/llvm/llvm-project/pull/13446
https://github.com/erichkeane approved this pull request.
Not sure I get what is going on, but nothing suspicious/no real comments.
https://github.com/llvm/llvm-project/pull/134461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
mizvekov wrote:
We can do a back port once the patch is settled, and it could wait until 20.2.
https://github.com/llvm/llvm-project/pull/134461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/134461
>From 9411de369476b24d56fbd495bcf4c76def2c4fe1 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 31 Mar 2025 17:19:18 -0300
Subject: [PATCH] [clang] fix partial ordering of NTTP packs
This fixes partia
@@ -6837,64 +6846,55 @@ ExprResult
Sema::CheckTemplateArgument(NonTypeTemplateParmDecl *Param,
assert(!ParamType.hasQualifiers() &&
"non-type template parameter type cannot be qualified");
+ // If either the parameter has a dependent type or the argument is
+ //
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/134461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6837,64 +6846,55 @@ ExprResult
Sema::CheckTemplateArgument(NonTypeTemplateParmDecl *Param,
assert(!ParamType.hasQualifiers() &&
"non-type template parameter type cannot be qualified");
+ // If either the parameter has a dependent type or the argument is
+ //
@@ -6837,64 +6846,55 @@ ExprResult
Sema::CheckTemplateArgument(NonTypeTemplateParmDecl *Param,
assert(!ParamType.hasQualifiers() &&
"non-type template parameter type cannot be qualified");
+ // If either the parameter has a dependent type or the argument is
+ //
@@ -6250,9 +6171,10 @@ FunctionDecl
*Sema::getMoreConstrainedFunction(FunctionDecl *FD1,
/// TemplateDecl or {Class,Var}TemplatePartialSpecializationDecl.
/// \param T1 The injected-class-name of P1 (faked for a variable template).
/// \param T2 The injected-class-name of P2 (
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/134461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 approved this pull request.
LGTM in general, but please wait for a few days before you commit.
https://github.com/llvm/llvm-project/pull/134461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Matheus Izvekov (mizvekov)
Changes
This fixes partial ordering of pack expansions of NTTPs, by procedding with the
check using the pattern of the NTTP through the rules of the non-pack case.
This also unifies almost all of the different v
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/134461
This fixes partial ordering of pack expansions of NTTPs, by procedding with the
check using the pattern of the NTTP through the rules of the non-pack case.
This also unifies almost all of the different version
13 matches
Mail list logo
