shafik wrote:
For future reference the summary here is not really sufficient. Since this what
usually goes in the git log they should be enough details for folks reading the
git log to understand what the change was.
The summary should explain the problem and provide a summary of the fix as we
efriedma-quic wrote:
Opened #104738 as a followup.
https://github.com/llvm/llvm-project/pull/104666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/104666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-barannikov approved this pull request.
https://github.com/llvm/llvm-project/pull/104666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -15567,12 +15567,13 @@ bool ComplexExprEvaluator::VisitBinaryOperator(const
BinaryOperator *E) {
HandleComplexComplexDiv(A, B, C, D, ResR, ResI);
}
} else {
- if (RHS.getComplexIntReal() == 0 && RHS.getComplexIntImag() == 0)
-return Error(E, d
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/104666
>From b58b9c3ad5fb2b37715ba9f52c905b6961159f0c Mon Sep 17 00:00:00 2001
From: c8ef
Date: Sat, 17 Aug 2024 05:42:39 +
Subject: [PATCH 1/4] [clang] fix divide by zero in ComplexExprEvaluator
---
clang/lib/AST/Ex
@@ -15567,12 +15567,13 @@ bool ComplexExprEvaluator::VisitBinaryOperator(const
BinaryOperator *E) {
HandleComplexComplexDiv(A, B, C, D, ResR, ResI);
}
} else {
- if (RHS.getComplexIntReal() == 0 && RHS.getComplexIntImag() == 0)
-return Error(E, d
c8ef wrote:
Yes, please. That would be great.
https://github.com/llvm/llvm-project/pull/104666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@c8ef you need me to merge that for you?
https://github.com/llvm/llvm-project/pull/104666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/104666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/104666
>From b58b9c3ad5fb2b37715ba9f52c905b6961159f0c Mon Sep 17 00:00:00 2001
From: c8ef
Date: Sat, 17 Aug 2024 05:42:39 +
Subject: [PATCH 1/3] [clang] fix divide by zero in ComplexExprEvaluator
---
clang/lib/AST/Ex
@@ -0,0 +1,3 @@
+// RUN: %clang_cc1 -fsyntax-only %s
+
+auto f() { return 43273096 / 65536j; }
c8ef wrote:
Thank you for your suggestion! I have relocated the test case and included the
relevant release note.
https://github.com/llvm/llvm-project/pull/104666
___
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/104666
>From b58b9c3ad5fb2b37715ba9f52c905b6961159f0c Mon Sep 17 00:00:00 2001
From: c8ef
Date: Sat, 17 Aug 2024 05:42:39 +
Subject: [PATCH 1/2] [clang] fix divide by zero in ComplexExprEvaluator
---
clang/lib/AST/Ex
cor3ntin wrote:
This change needs a release note.
Please add an entry to `clang/docs/ReleaseNotes.rst` in the section the most
adapted to the change, and referencing any Github issue this change fixes.
Thanks!
The fix itself looks good
https://github.com/llvm/llvm-project/pull/104666
@@ -0,0 +1,3 @@
+// RUN: %clang_cc1 -fsyntax-only %s
+
+auto f() { return 43273096 / 65536j; }
cor3ntin wrote:
can you move that to , for example
`clang/test/SemaCXX/constant-expression-cxx11.cpp`
and make sure that actually always get evaluated?
maybe `constexp
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (c8ef)
Changes
fix: #55390.
---
Full diff: https://github.com/llvm/llvm-project/pull/104666.diff
2 Files Affected:
- (modified) clang/lib/AST/ExprConstant.cpp (+4-3)
- (added) clang/test/SemaCXX/complex-div.cpp (+3)
``d
https://github.com/c8ef created https://github.com/llvm/llvm-project/pull/104666
fix: #55390.
>From b58b9c3ad5fb2b37715ba9f52c905b6961159f0c Mon Sep 17 00:00:00 2001
From: c8ef
Date: Sat, 17 Aug 2024 05:42:39 +
Subject: [PATCH] [clang] fix divide by zero in ComplexExprEvaluator
---
clang/
17 matches
Mail list logo
