https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/97846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chestnykh wrote:
> > > > > LGTM but please add a release note to clang/docs/ReleaseNotes.rst so
> > > > > users know about the fix as well.
> > > >
> > > >
> > > > Note that only clang 19 has `constexpr` support in C23.
> > > > https://godbolt.org/z/4bThdsqK5 Release note saying that support
https://github.com/chestnykh updated
https://github.com/llvm/llvm-project/pull/97846
>From 0619f787112c18c559959eb50086b412ebad5839 Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Fri, 5 Jul 2024 20:40:32 +0300
Subject: [PATCH] [clang][C23] Use internal linkage for C23 constexpr vars.
Se
AaronBallman wrote:
> > > > LGTM but please add a release note to clang/docs/ReleaseNotes.rst so
> > > > users know about the fix as well.
> > >
> > >
> > > Note that only clang 19 has `constexpr` support in C23.
> > > https://godbolt.org/z/4bThdsqK5 Release note saying that support has been
chestnykh wrote:
> > > LGTM but please add a release note to clang/docs/ReleaseNotes.rst so
> > > users know about the fix as well.
> >
> >
> > Note that only clang 19 has `constexpr` support in C23.
> > https://godbolt.org/z/4bThdsqK5 Release note saying that support has been
> > implemente
AaronBallman wrote:
> > LGTM but please add a release note to clang/docs/ReleaseNotes.rst so users
> > know about the fix as well.
>
> Note that only clang 19 has `constexpr` support in C23.
> https://godbolt.org/z/4bThdsqK5 Release note saying that support has been
> implemented is already t
https://github.com/chestnykh updated
https://github.com/llvm/llvm-project/pull/97846
>From 7a3f28574377bb6139971039ca6da5d299c2228d Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Fri, 5 Jul 2024 20:40:32 +0300
Subject: [PATCH 1/2] [clang] Use internal linkage for c23 constexpr vars.
See
https://github.com/chestnykh updated
https://github.com/llvm/llvm-project/pull/97846
>From 7a3f28574377bb6139971039ca6da5d299c2228d Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Fri, 5 Jul 2024 20:40:32 +0300
Subject: [PATCH 1/2] [clang] Use internal linkage for c23 constexpr vars.
See
chestnykh wrote:
Release notes added
https://github.com/llvm/llvm-project/pull/97846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chestnykh updated
https://github.com/llvm/llvm-project/pull/97846
>From 7a3f28574377bb6139971039ca6da5d299c2228d Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Fri, 5 Jul 2024 20:40:32 +0300
Subject: [PATCH 1/2] [clang] Use internal linkage for c23 constexpr vars.
See
Fznamznon wrote:
> LGTM but please add a release note to clang/docs/ReleaseNotes.rst so users
> know about the fix as well.
Note that only clang 19 has `constexpr` support in C23.
https://godbolt.org/z/4bThdsqK5
https://github.com/llvm/llvm-project/pull/97846
_
chestnykh wrote:
> LGTM but please add a release note to clang/docs/ReleaseNotes.rst so users
> know about the fix as well.
>
> Once that's added, will you need someone to land the changes on your behalf?
@AaronBallman , yes, i will need this. I'm going to add release notes right now.
https:/
https://github.com/AaronBallman approved this pull request.
LGTM but please add a release note to clang/docs/ReleaseNotes.rst so users know
about the fix as well.
Once that's added, will you need someone to land the changes on your behalf?
https://github.com/llvm/llvm-project/pull/97846
__
https://github.com/Fznamznon approved this pull request.
LGTM, though please let others to take a look too.
https://github.com/llvm/llvm-project/pull/97846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/chestnykh updated
https://github.com/llvm/llvm-project/pull/97846
>From 7a3f28574377bb6139971039ca6da5d299c2228d Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Fri, 5 Jul 2024 20:40:32 +0300
Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars.
See C23
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 3bb25636414ee5b5eaf99c0bdcc191052c9d7ffb
b8252ed88a15cda147b2f62329a9369130a8d694 --
@@ -4428,10 +4428,14 @@ void Parser::ParseDeclarationSpecifiers(
// constexpr, consteval, constinit specifiers
case tok::kw_constexpr:
- if (getLangOpts().C23)
+ if (getLangOpts().C23) {
Diag(Tok, diag::warn_c23_compat_keyword) << Tok.getName();
-
https://github.com/chestnykh edited
https://github.com/llvm/llvm-project/pull/97846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chestnykh updated
https://github.com/llvm/llvm-project/pull/97846
>From b8252ed88a15cda147b2f62329a9369130a8d694 Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Fri, 5 Jul 2024 20:40:32 +0300
Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars.
See C23
https://github.com/chestnykh ready_for_review
https://github.com/llvm/llvm-project/pull/97846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chestnykh updated
https://github.com/llvm/llvm-project/pull/97846
>From 70a5e96c9489ef46c5c17106178bf703eab8f8ad Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Fri, 5 Jul 2024 20:40:32 +0300
Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars.
Set `st
@@ -4428,10 +4428,14 @@ void Parser::ParseDeclarationSpecifiers(
// constexpr, consteval, constinit specifiers
case tok::kw_constexpr:
- if (getLangOpts().C23)
+ if (getLangOpts().C23) {
Diag(Tok, diag::warn_c23_compat_keyword) << Tok.getName();
-
@@ -4428,10 +4428,14 @@ void Parser::ParseDeclarationSpecifiers(
// constexpr, consteval, constinit specifiers
case tok::kw_constexpr:
- if (getLangOpts().C23)
+ if (getLangOpts().C23) {
Diag(Tok, diag::warn_c23_compat_keyword) << Tok.getName();
-
https://github.com/chestnykh converted_to_draft
https://github.com/llvm/llvm-project/pull/97846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chestnykh updated
https://github.com/llvm/llvm-project/pull/97846
>From ecf8360b1ca201eeb8887214477eb8ffeb5f088f Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Fri, 5 Jul 2024 20:40:32 +0300
Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars.
Set `st
https://github.com/chestnykh updated
https://github.com/llvm/llvm-project/pull/97846
>From 20adb1c05dc59cc0a4b3969824f75c2d9c612755 Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Fri, 5 Jul 2024 20:40:32 +0300
Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars.
Set `st
https://github.com/chestnykh updated
https://github.com/llvm/llvm-project/pull/97846
>From 20adb1c05dc59cc0a4b3969824f75c2d9c612755 Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Fri, 5 Jul 2024 20:40:32 +0300
Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars.
Set `st
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Dmitriy Chestnykh (chestnykh)
Changes
Set `static` storage class specifier for such decls to have `internal` linkage
in produced IR and then in the object file.
Fix #97830
---
Full diff: https://github.com/llvm/llvm-project/pull/97846.dif
https://github.com/chestnykh updated
https://github.com/llvm/llvm-project/pull/97846
>From ec1f0f0fe626db9da1437ed414f8d080c750cb45 Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Fri, 5 Jul 2024 20:40:32 +0300
Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars.
Set `st
https://github.com/chestnykh created
https://github.com/llvm/llvm-project/pull/97846
Set `static` storage class specifier for such decls to have `internal` linkage
in produced IR and then in the object file.
Fix #97830
>From ec1f0f0fe626db9da1437ed414f8d080c750cb45 Mon Sep 17 00:00:00 2001
Fro
30 matches
Mail list logo
