https://github.com/Prabhuk closed
https://github.com/llvm/llvm-project/pull/124824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
LGTM. Lets try to follow up w/ something on the llvm side too though.
https://github.com/llvm/llvm-project/pull/124824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/124824
>From 270c260ba8160c71c6602fcb91a635368ee09a88 Mon Sep 17 00:00:00 2001
From: Prabhu Karthikeyan Rajasekaran
Date: Tue, 28 Jan 2025 19:07:06 +
Subject: [PATCH 1/7] [clang] Abort on unsupported uefi triples.
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/124824
>From 270c260ba8160c71c6602fcb91a635368ee09a88 Mon Sep 17 00:00:00 2001
From: Prabhu Karthikeyan Rajasekaran
Date: Tue, 28 Jan 2025 19:07:06 +
Subject: [PATCH 1/5] [clang] Abort on unsupported uefi triples.
@@ -637,6 +637,10 @@ static llvm::Triple computeTargetTriple(const Driver &D,
}
}
+ // Currently the only architecture supported by *-uefi triples are x86_64.
+ if(Target.isUEFI() && Target.getArch() != llvm::Triple::x86_64)
rnk wrote:
```suggestion
rnk wrote:
+1 for a test
https://github.com/llvm/llvm-project/pull/124824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Prabhuk edited
https://github.com/llvm/llvm-project/pull/124824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits