[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-06 Thread Thurston Dang via cfe-commits
thurstond wrote: > This will be fixed here: #134560 Thank you! https://github.com/llvm/llvm-project/pull/132748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-06 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: This will be fixed here: https://github.com/llvm/llvm-project/pull/134560 https://github.com/llvm/llvm-project/pull/132748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-05 Thread Thurston Dang via cfe-commits
thurstond wrote: If it is not quick and easy to fix forward, please consider reverting in the meantime, so that the buildbots can be green and provide useful feedback to contributors. Thanks! https://github.com/llvm/llvm-project/pull/132748 ___ cfe-c

[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-05 Thread Thurston Dang via cfe-commits
thurstond wrote: > @thurstond Well can you provide a more recent buildbot failure link where > #130182 is not on the list of possible culpirits? Because the link @fmayer > provided for sure included it. @mizvekov I localized the MSan error to this patch by re-running the buildbot script with

[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-05 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: @thurstond Well can you provide a more recent buildbot failure link where https://github.com/llvm/llvm-project/pull/130182 is not on the list of possible culpirits? Because the link @fmayer provided for sure included it. https://github.com/llvm/llvm-project/pull/132748

[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-05 Thread Thurston Dang via cfe-commits
thurstond wrote: > @fmayer this patch touches nowhere near where those backtraces indicate. > #130182 is a far more likely culprit. #130182 cannot be the cause of the ongoing MSan buildbot failures, because it was already reverted two days ago in #134239 https://github.com/llvm/llvm-project/

[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-05 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: @fmayer this patch touches nowhere near where those backtraces indicate. https://github.com/llvm/llvm-project/pull/130182 is a far more likely culprit. https://github.com/llvm/llvm-project/pull/132748 ___ cfe-commits mailing list cfe-co

[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-05 Thread via cfe-commits
@@ -1302,6 +1302,8 @@ void TextNodeDumper::dumpBareTemplateName(TemplateName TN) { OS << " index " << STS->getIndex(); if (std::optional PackIndex = STS->getPackIndex()) OS << " pack_index " << *PackIndex; +if (STS->getFinal()) + OS << " final";

[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-04 Thread Florian Mayer via cfe-commits
fmayer wrote: Looks like this CL broke the MSAN bot: https://lab.llvm.org/buildbot/#/builders/169/builds/10068 https://github.com/llvm/llvm-project/pull/132748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-04 Thread Jan Voung via cfe-commits
jvoung wrote: > @ymand @jvoung I'd like to know if you tried this patch within google and > within your tooling, and if you can report whether it is suited and if there > is any noteworthy performance impact. Ok, I tried some experiments. Our nullability analysis tests do now pass without the

[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `clang` at step 5 "compile-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/2721 Here is the relevant

[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-02 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/132748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Track final substitution for Subst* AST nodes (PR #132748)

2025-04-01 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/132748 >From b50ea7d744280bdfb97f0abaeb10d088d502e81a Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 22 Mar 2025 16:03:04 -0300 Subject: [PATCH 1/4] [clang] Track final substitution for SubstTemplateTempla