[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/66641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

https://github.com/cor3ntin approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/66641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/66641 >From ef66dbe5f9a5b9071e994a5d8f2b6b48b6d5b446 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 18 Sep 2023 19:55:45 +0800 Subject: [PATCH 1/2] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation

[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

zyn0217 wrote: No problem! And here it is. PTAL, thanks! @cor3ntin https://github.com/llvm/llvm-project/pull/66641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/66641 >From ba9aa0ffe006ecdd8685c7e62be8c4c776391ec2 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 18 Sep 2023 19:55:45 +0800 Subject: [PATCH 1/2] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation

[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

cor3ntin wrote: @zyn0217 Can you add a release note indicating that #63898 was fixed? Otherwise it looks good to me. Sorry for the long delay, feel free to ping me again https://github.com/llvm/llvm-project/pull/66641 ___ cfe-commits mailing list cfe

[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

zyn0217 wrote: Invite @shafik and @cor3ntin to have a look at this. My apologies if I'm churning anyone's review backlog. Honestly, I have no idea who the appropriate reviewer/code owner is. :( https://github.com/llvm/llvm-project/pull/66641 ___ cfe-

[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

HighCommander4 wrote: I wonder if `TreeTransform::TransformUserDefinedLiteral()` should be doing something like `RebuildUserDefinedLiteral()`. Anyways, the patch looks reasonable to me but someone more familiar with Sema should review it. https://github.com/llvm/llvm-project/pull/66641 __

[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

zyn0217 wrote: Ping~ Looking for a review :) https://github.com/llvm/llvm-project/pull/66641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

llvmbot wrote: @llvm/pr-subscribers-clang Changes D63960 performs a tree transformation on AST to prevent evaluating constant expressions eagerly by removing recorded immediate consteval invocations from subexpressions. (See https://reviews.llvm.org/D63960#inline-600736 for its motivatio

[clang] [clang] Preserve UDL nodes in RemoveNestedImmediateInvocation (PR #66641)

https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/66641 D63960 performs a tree transformation on AST to prevent evaluating constant expressions eagerly by removing recorded immediate consteval invocations from subexpressions. (See https://reviews.llvm.org/D63960#inli