llvmbot wrote:
@llvm/pr-subscribers-clang
Author: marius doerner (mariusdr)
Changes
Closes #131432
Raise an error when placement new is used to modify a const-qualified variable
in a constexpr function.
Note that diag::note_constexpr_modify_const_type is used since the it is also
rais
mariusdr wrote:
Added release notes under "Bug Fixes to C++ Support". Thanks for the review.
https://github.com/llvm/llvm-project/pull/132460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
https://github.com/mariusdr created
https://github.com/llvm/llvm-project/pull/132460
Closes #131432
Raise an error when placement new is used to modify a const-qualified variable
in a constexpr function.
Note that diag::note_constexpr_modify_const_type is used since the it is also
raised wh
mariusdr wrote:
> Thanks. Will you need me to merge that for you?
Yes, please
https://github.com/llvm/llvm-project/pull/132460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
@mariusdr Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/132460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
Thanks.
Will you need me to merge that for you?
https://github.com/llvm/llvm-project/pull/132460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/mariusdr updated
https://github.com/llvm/llvm-project/pull/132460
>From d4af25b14fb21f50c3771cce4595ca5c1bb920a7 Mon Sep 17 00:00:00 2001
From: marius doerner
Date: Fri, 21 Mar 2025 20:19:57 +0100
Subject: [PATCH 1/3] [clang] Placement new error when modifying consts
Raise a
cor3ntin wrote:
This change needs a release note.
Please add an entry to `clang/docs/ReleaseNotes.rst` in the section the most
adapted to the change, and referencing any Github issue this change fixes.
Thanks!
https://github.com/llvm/llvm-project/pull/132460
___
https://github.com/mariusdr updated
https://github.com/llvm/llvm-project/pull/132460
>From d4af25b14fb21f50c3771cce4595ca5c1bb920a7 Mon Sep 17 00:00:00 2001
From: marius doerner
Date: Fri, 21 Mar 2025 20:19:57 +0100
Subject: [PATCH 1/2] [clang] Placement new error when modifying consts
Raise a
mariusdr wrote:
> The tests should go into a file not under `ByteCode/` since they aren't
> specific to the bytecode interpreter. There should be existing placement new
> tests in `SemaCXX/`.
Thanks for the hint, moved them to
clang/test/SemaCXX/cxx2c-constexpr-placement-new.cpp
https://gith
https://github.com/mariusdr updated
https://github.com/llvm/llvm-project/pull/132460
>From d4af25b14fb21f50c3771cce4595ca5c1bb920a7 Mon Sep 17 00:00:00 2001
From: marius doerner
Date: Fri, 21 Mar 2025 20:19:57 +0100
Subject: [PATCH 1/2] [clang] Placement new error when modifying consts
Raise a
tbaederr wrote:
The tests should go into a file not under `ByteCode/` since they aren't
specific to the bytecode interpreter. There should be existing placement new
tests in `SemaCXX/`.
https://github.com/llvm/llvm-project/pull/132460
___
cfe-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
14 matches
Mail list logo
