https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/119724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic approved this pull request.
https://github.com/llvm/llvm-project/pull/119724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kazutakahirata wrote:
@nikic Please take a look at the revised patch. Thanks!
https://github.com/llvm/llvm-project/pull/119724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -486,10 +486,10 @@ enum class TemplateSubstitutionKind : char {
const Decl *D = I->first;
llvm::PointerUnion &Stored =
newScope->LocalDecls[D];
-if (I->second.is()) {
- Stored = I->second.get();
+if (isa(I->second)) {
+
https://github.com/kazutakahirata updated
https://github.com/llvm/llvm-project/pull/119724
>From 6fc978bce4321bb24ade49f2f6fde0c7ccd0002b Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Thu, 12 Dec 2024 09:06:22 -0800
Subject: [PATCH 1/2] [clang] Migrate away from PointerUnion::{is,get} (NFC)
@@ -486,10 +486,10 @@ enum class TemplateSubstitutionKind : char {
const Decl *D = I->first;
llvm::PointerUnion &Stored =
newScope->LocalDecls[D];
-if (I->second.is()) {
- Stored = I->second.get();
+if (isa(I->second)) {
+
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/119724
Note that PointerUnion::{is,get} have been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
I'm not touching
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
Author: Kazu Hirata (kazutakahirata)
Changes
Note that PointerUnion::{is,get} have been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast<
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Kazu Hirata (kazutakahirata)
Changes
Note that PointerUnion::{is,get} have been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
Note that PointerUnion::{is,get} have been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
I'm n
10 matches
Mail list logo