[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

stefson wrote: @ostannard can you please backport this patch into the 19.x branch, and also other relevant changes to the musttail issue? clang-19.1.0 was released very broken on arm due to this. https://github.com/llvm/llvm-project/pull/109255 ___

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

https://github.com/ostannard closed https://github.com/llvm/llvm-project/pull/109255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

https://github.com/hokein approved this pull request. Thanks, still looks good. https://github.com/llvm/llvm-project/pull/109255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

@@ -267,3 +267,30 @@ namespace ns {} void TestCallNonValue() { [[clang::musttail]] return ns; // expected-error {{unexpected namespace name 'ns': expected expression}} } + +// Test diagnostics for lifetimes of local variables, which end earlier for a +// musttail call than f

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

@@ -637,6 +637,11 @@ return value must be trivially destructible. The calling convention of the caller and callee must match, and they must not be variadic functions or have old style K&R C function declarations. +The lifetimes of all local variables and function parameters e

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

https://github.com/ostannard updated https://github.com/llvm/llvm-project/pull/109255 >From 85ac319257785f88fd27a533fffde7aab20c8d8d Mon Sep 17 00:00:00 2001 From: Oliver Stannard Date: Wed, 18 Sep 2024 16:22:41 +0100 Subject: [PATCH 1/5] [clang] Lifetime of locals must end before musttail call

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/109255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

@@ -637,6 +637,11 @@ return value must be trivially destructible. The calling convention of the caller and callee must match, and they must not be variadic functions or have old style K&R C function declarations. +The lifetimes of all local variables and function parameters e

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

@@ -267,3 +267,30 @@ namespace ns {} void TestCallNonValue() { [[clang::musttail]] return ns; // expected-error {{unexpected namespace name 'ns': expected expression}} } + +// Test diagnostics for lifetimes of local variables, which end earlier for a +// musttail call than f

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

https://github.com/hokein approved this pull request. Thanks, it looks good, just a few nits. https://github.com/llvm/llvm-project/pull/109255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

https://github.com/ostannard updated https://github.com/llvm/llvm-project/pull/109255 >From 85ac319257785f88fd27a533fffde7aab20c8d8d Mon Sep 17 00:00:00 2001 From: Oliver Stannard Date: Wed, 18 Sep 2024 16:22:41 +0100 Subject: [PATCH 1/3] [clang] Lifetime of locals must end before musttail call

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

https://github.com/hokein commented: I think it warrants a mention in the release notes. https://github.com/llvm/llvm-project/pull/109255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Oliver Stannard (ostannard) Changes The lifetimes of local variables and function parameters must end before the call to a [[clang::musttail]] function, instead of before the return, because we will not have a stack frame to hold them whe

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

https://github.com/ostannard updated https://github.com/llvm/llvm-project/pull/109255 >From 85ac319257785f88fd27a533fffde7aab20c8d8d Mon Sep 17 00:00:00 2001 From: Oliver Stannard Date: Wed, 18 Sep 2024 16:22:41 +0100 Subject: [PATCH 1/2] [clang] Lifetime of locals must end before musttail call

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 30cdf1e959d2e4dee1c871ff37470dcdb7e8d099 85ac319257785f88fd27a533fffde7aab20c8d8d --e

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

https://github.com/ostannard created https://github.com/llvm/llvm-project/pull/109255 The lifetimes of local variables and function parameters must end before the call to a [[clang::musttail]] function, instead of before the return, because we will not have a stack frame to hold them when doin