llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux`
running on `sanitizer-buildbot7` while building `clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/51/builds/12901
Here is the relevant piece of the
Fznamznon wrote:
Ooops, I'll fix the bots quickly
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`ppc64le-lld-multistage-test` running on `ppc64le-lld-multistage-test` while
building `clang` at step 12 "build-stage2-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/168/builds/9949
He
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `sanitizer-ppc64le-linux`
running on `ppc64le-sanitizer` while building `clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/72/builds/9355
Here is the relevant piece of the bu
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/127629
>From 700ec6f78c0a24729801bea381bafbcafb06826b Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Tue, 18 Feb 2025 05:12:07 -0800
Subject: [PATCH 1/3] [clang] Introduce "binary" StringLiteral for #e
@@ -1752,7 +1752,8 @@ enum class StringLiteralKind {
UTF8,
UTF16,
UTF32,
- Unevaluated
+ Unevaluated,
+ Binary
cor3ntin wrote:
Yup, Thanks!
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits m
Fznamznon wrote:
> No changelog because we want to backport?
No changelog because I forgot. Should we backport though?
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/127629
>From 700ec6f78c0a24729801bea381bafbcafb06826b Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Tue, 18 Feb 2025 05:12:07 -0800
Subject: [PATCH 1/3] [clang] Introduce "binary" StringLiteral for #e
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1752,7 +1752,8 @@ enum class StringLiteralKind {
UTF8,
UTF16,
UTF32,
- Unevaluated
+ Unevaluated,
+ Binary
Fznamznon wrote:
I added some comment. Do you think it turned out helpful?
https://github.com/llvm/llvm-project/pull/127629
___
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> > No changelog because we want to backport?
>
> No changelog because I forgot. Should we backport though?
This seems simple enough to warrant backporting.
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
No changelog because we want to backport?
LGTM but i think this could use some comments
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
@@ -1752,7 +1752,8 @@ enum class StringLiteralKind {
UTF8,
UTF16,
UTF32,
- Unevaluated
+ Unevaluated,
+ Binary
cor3ntin wrote:
Can you add a comment explaining this is for embed?
I'm sorry it took me a while to understand how this patch works.
(The r
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1332,6 +1334,11 @@ StringLiteral::getLocationOfByte(unsigned ByteNo, const
SourceManager &SM,
const LangOptions &Features,
const TargetInfo &Target, unsigned
*StartToken,
un
https://github.com/AaronBallman commented:
Thanks for this! It also needs a release note for the fix. :-)
In general, I think this seems reasonable, but I'd like confirmation from
@cor3ntin given his somewhat recent thinking about unevaluated string literals
and where those end up touching the
@@ -1332,6 +1334,11 @@ StringLiteral::getLocationOfByte(unsigned ByteNo, const
SourceManager &SM,
const LangOptions &Features,
const TargetInfo &Target, unsigned
*StartToken,
un
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Fznamznon wrote:
ping
https://github.com/llvm/llvm-project/pull/127629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4965,9 +4966,9 @@ class EmbedExpr final : public Expr {
assert(EExpr && CurOffset != ULLONG_MAX &&
"trying to dereference an invalid iterator");
IntegerLiteral *N = EExpr->FakeChildNode;
- StringRef DataRef = EExpr->Data->BinaryData->getBytes()
@@ -4965,9 +4966,9 @@ class EmbedExpr final : public Expr {
assert(EExpr && CurOffset != ULLONG_MAX &&
"trying to dereference an invalid iterator");
IntegerLiteral *N = EExpr->FakeChildNode;
- StringRef DataRef = EExpr->Data->BinaryData->getBytes()
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 93d3e20bb226507c6eb777cfb15ea13f2cd129e8
700ec6f78c0a24729801bea381bafbcafb06826b --e
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/127629
>From 700ec6f78c0a24729801bea381bafbcafb06826b Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Tue, 18 Feb 2025 05:12:07 -0800
Subject: [PATCH 1/2] [clang] Introduce "binary" StringLiteral for #e
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mariya Podchishchaeva (Fznamznon)
Changes
StringLiteral is used as internal data of EmbedExpr and we directly use it as
an initializer if a single EmbedExpr appears in the initializer list of a char
array. It is fast and convenient, but i
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/127629
StringLiteral is used as internal data of EmbedExpr and we directly use it as
an initializer if a single EmbedExpr appears in the initializer list of a char
array. It is fast and convenient, but it is causing
30 matches
Mail list logo
