[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Eric Astor via cfe-commits
https://github.com/ericastor updated https://github.com/llvm/llvm-project/pull/115924 >From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001 From: Eric Astor Date: Tue, 12 Nov 2024 17:37:42 + Subject: [PATCH 1/8] [clang] Instantiate attributes on other decl types Start pro

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Eric Astor via cfe-commits
https://github.com/ericastor closed https://github.com/llvm/llvm-project/pull/115924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/115924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Eric Astor via cfe-commits
ericastor wrote: > Test seems to have disappeared entirely! Whoops. Apologies, missed that I'd forgotten to track the new file. https://github.com/llvm/llvm-project/pull/115924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Eric Astor via cfe-commits
https://github.com/ericastor updated https://github.com/llvm/llvm-project/pull/115924 >From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001 From: Eric Astor Date: Tue, 12 Nov 2024 17:37:42 + Subject: [PATCH 1/8] [clang] Instantiate attributes on other decl types Start pro

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Test seems to have disappeared entirely! https://github.com/llvm/llvm-project/pull/115924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Eric Astor via cfe-commits
https://github.com/ericastor updated https://github.com/llvm/llvm-project/pull/115924 >From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001 From: Eric Astor Date: Tue, 12 Nov 2024 17:37:42 + Subject: [PATCH 1/7] [clang] Instantiate attributes on other decl types Start pro

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Eric Astor via cfe-commits
ericastor wrote: > test needs some simplification/help, else this is fine. Thanks, I was mimicking another file that apparently isn't following best practices. Done! https://github.com/llvm/llvm-project/pull/115924 ___ cfe-commits mailing list cfe-co

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Eric Astor via cfe-commits
https://github.com/ericastor updated https://github.com/llvm/llvm-project/pull/115924 >From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001 From: Eric Astor Date: Tue, 12 Nov 2024 17:37:42 + Subject: [PATCH 1/7] [clang] Instantiate attributes on other decl types Start pro

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: test needs some simplification/help, else this is fine. https://github.com/llvm/llvm-project/pull/115924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Erich Keane via cfe-commits
@@ -1,4 +1,64 @@ -// RUN: %clang_cc1 -std=gnu++20 -fsyntax-only -verify %s +// RUN: split-file %s %t +// RUN: %clang_cc1 -std=gnu++20 -fsyntax-only -ast-dump -verify %t/good_annotate.cpp | FileCheck %s erichkeane wrote: This looks like it should just be a separa

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Erich Keane via cfe-commits
@@ -1,4 +1,64 @@ -// RUN: %clang_cc1 -std=gnu++20 -fsyntax-only -verify %s +// RUN: split-file %s %t +// RUN: %clang_cc1 -std=gnu++20 -fsyntax-only -ast-dump -verify %t/good_annotate.cpp | FileCheck %s +// RUN: %clang_cc1 -std=gnu++20 -fsyntax-only -verify %t/bad_annotate.cpp +//

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-15 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/115924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-14 Thread Eric Astor via cfe-commits
https://github.com/ericastor updated https://github.com/llvm/llvm-project/pull/115924 >From da2e66a6a2636bf1a1ab2e25afdbd29095b6db3f Mon Sep 17 00:00:00 2001 From: Eric Astor Date: Tue, 12 Nov 2024 17:37:42 + Subject: [PATCH 1/6] [clang] Instantiate attributes on other decl types Start pro

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-14 Thread Eric Astor via cfe-commits
ericastor wrote: Alright, I've scoped this change back down to just LabelDecls, and added tests that avoid the use of plugins. I appreciate your review! https://github.com/llvm/llvm-project/pull/115924 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [clang] Instantiate attributes on LabelDecls (PR #115924)

2024-11-14 Thread Eric Astor via cfe-commits
https://github.com/ericastor edited https://github.com/llvm/llvm-project/pull/115924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits