AaronBallman wrote:
Sorry about the delayed response.. gmail decided that reviews were spam and so
I didn't notice a whole lot of email until I thought to ask myself why the
community reviews seemed so quiet lately. :-D
I'm going to revert the changes entirely until we can figure out a better
mikaelholmen wrote:
We also see the ASan complaints on ```Parser/parser_overflow.c``` in downstream
bots for several days now.
A workaround would be appreciated if a real fix is hard.
https://github.com/llvm/llvm-project/pull/104717
___
cfe-commits ma
dyung wrote:
Ping, can we maybe get the test `Parser/parser_overflow.c` disabled for
ASan/UBSan configurations?
https://github.com/llvm/llvm-project/pull/104717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
dyung wrote:
We are also seeing the test `Parser/parser_overflow.c` failing when run with
ASan or UBSan. Running with `-fbracket-depth` options, I find that on my linux
box, the test starts to segfault when the value is >= 1022:
```
dyung@aldebaran:~/src/upstream/llvm_clean_git/clang/test/Parse
AaronBallman wrote:
> ```
> $ ./build/bin/clang -fsyntax-only -DHUGE 2>&1
> clang/test/Parser/parser_overflow.c -fbracket-depth=2048
> Segmentation fault
>
> $ ./build/bin/clang -fsyntax-only -DHUGE 2>&1
> clang/test/Parser/parser_overflow.c -fbracket-depth=2045
> clang/test/Parser/parser_over
cor3ntin wrote:
are you able to produce a stack trace?
https://github.com/llvm/llvm-project/pull/104717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Keenuts wrote:
```
$ ./build/bin/clang -fsyntax-only -DHUGE 2>&1
clang/test/Parser/parser_overflow.c -fbracket-depth=2048
Segmentation fault
$ ./build/bin/clang -fsyntax-only -DHUGE 2>&1
clang/test/Parser/parser_overflow.c -fbracket-depth=2045
clang/test/Parser/parser_overflow.c:11:2049: fatal
AaronBallman wrote:
> Shall the max depth be reduced a bit?
Do you still get the crash if you pass `-fbracket-depth 1024` in the first RUN
line of the test?
https://github.com/llvm/llvm-project/pull/104717
___
cfe-commits mailing list
cfe-commits@lis
AmrDeveloper wrote:
> Hello! Looks like increasing the max depth makes the debug build stack
> overflow. In release builds, `clang/test/Parser/parser_overflow.c` is fine,
> but in debug builds, the stack size reaches my OS limit (8MB) and crashes.
> Shall the max depth be reduced a bit?
@Aaro
Keenuts wrote:
Hello!
Looks like increasing the max depth makes the debug build stack overflow.
In release builds, `clang/test/Parser/parser_overflow.c` is fine, but in debug
builds, the stack size reaches my OS limit (8MB) and crashes.
Shall the max depth be reduced a bit?
https://github.com/l
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building
`clang` at step 6 "test-openmp".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/30/builds/4339
Here is the relevant piece of th
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/104717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/104717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7959,7 +7959,7 @@ def fapply_global_visibility_to_externs : Flag<["-"],
"fapply-global-visibility-
MarshallingInfoFlag>;
def fbracket_depth : Separate<["-"], "fbracket-depth">,
HelpText<"Maximum nesting level for parentheses, brackets, and braces">,
- MarshallingInfoI
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/104717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/104717
>From 42eee38e3139110ad95bde697c38b23046dd2c77 Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Sun, 18 Aug 2024 20:05:38 +0200
Subject: [PATCH] [clang] Increase the default expression nesting limit
Incre
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/104717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7959,7 +7959,7 @@ def fapply_global_visibility_to_externs : Flag<["-"],
"fapply-global-visibility-
MarshallingInfoFlag>;
def fbracket_depth : Separate<["-"], "fbracket-depth">,
HelpText<"Maximum nesting level for parentheses, brackets, and braces">,
- MarshallingInfoI
https://github.com/AaronBallman commented:
Can you also add a release note to `clang/docs/ReleaseNotes.rst` so users know
that the default has been bumped?
https://github.com/llvm/llvm-project/pull/104717
___
cfe-commits mailing list
cfe-commits@lists
AmrDeveloper wrote:
@AaronBallman
https://github.com/llvm/llvm-project/pull/104717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/104717
>From 6635b518d0413273831dc730b89b27780c6f2419 Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Sun, 18 Aug 2024 20:05:38 +0200
Subject: [PATCH] [clang] Increase the default expression nesting limit
Incre
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/104717
>From 8add317c1997297980a5cda12ee750f4bc24e31f Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Sun, 18 Aug 2024 20:05:38 +0200
Subject: [PATCH] [clang] Increase the default expression nesting limit
Incre
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Amr Hesham (AmrDeveloper)
Changes
Increase the default expression nesting limit from 256 to 1024
Fixes: #94728
Compile time with different Bracket depth
Clang version 20.0.0git (https://github.com/AmrDeveloper/llvm-project.git
673b9e08d
https://github.com/AmrDeveloper created
https://github.com/llvm/llvm-project/pull/104717
Increase the default expression nesting limit from 256 to 1024
Fixes: #94728
Compile time with different Bracket depth
Clang version 20.0.0git (https://github.com/AmrDeveloper/llvm-project.git
673b9e08de
24 matches
Mail list logo
