bolshakov-a wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
Merging at @bolshakov-a's request
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
Still looks good, thanks
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bolshakov-a updated
https://github.com/llvm/llvm-project/pull/71077
>From 4435d1ed5ed4785be7df35c129332359d89f132b Mon Sep 17 00:00:00 2001
From: Bolshakov
Date: Thu, 2 Nov 2023 19:20:27 +0300
Subject: [PATCH] [clang] Improve bit-field in ref NTTP diagnostic
Prior to this, a
https://github.com/bolshakov-a updated
https://github.com/llvm/llvm-project/pull/71077
>From e5ad8f5b00a297ef745e1b9341df32b80a7c6b77 Mon Sep 17 00:00:00 2001
From: Bolshakov
Date: Thu, 2 Nov 2023 19:20:27 +0300
Subject: [PATCH] [clang] Improve bit-field in ref NTTP diagnostic
Prior to this, a
bolshakov-a wrote:
I want just note that it is probably not an improvement from the user's point
of view, just a change of wording.
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
shafik wrote:
> > Can you add a release note?
>
> Do you think this small diagnostic wording change is worth noting in relnotes?
Yes, we have a `Improvments to clang diagnostics` section.
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commi
https://github.com/shafik approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bolshakov-a updated
https://github.com/llvm/llvm-project/pull/71077
>From ff1b0d96e7beef51a082d59548c49b9c02d79eb0 Mon Sep 17 00:00:00 2001
From: Bolshakov
Date: Thu, 2 Nov 2023 19:20:27 +0300
Subject: [PATCH] [clang] Improve bit-field in ref NTTP diagnostic
Prior to this, a
@@ -5992,6 +5992,15 @@ static ExprResult BuildConvertedConstantExpression(Sema
&S, Expr *From,
/*InOverloadResolution=*/false,
/*AllowObjCWritebackConversion=*/false,
/*AllowE
bolshakov-a wrote:
> Can you add a release note?
Do you think this small diagnostic wording change is worth noting in relnotes?
> Do we need more tests in other contexts where a converted constant expression
> is used?
Seems like constant expressions converted to references may currently only
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9f78edbd20ed922cced9482f7791deb9899a6d82
bc2ea1ab74b613f700b11390a4715a0f2bec10e7 --
https://github.com/bolshakov-a updated
https://github.com/llvm/llvm-project/pull/71077
>From bc2ea1ab74b613f700b11390a4715a0f2bec10e7 Mon Sep 17 00:00:00 2001
From: Bolshakov
Date: Thu, 2 Nov 2023 19:20:27 +0300
Subject: [PATCH] [clang] Improve bit-field in ref NTTP diagnostic
Prior to this, a
https://github.com/cor3ntin commented:
Can you add a release note? Thanks.
Do we need more tests in other contexts where a converted constant expression
is used?
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@
@@ -5992,6 +5992,15 @@ static ExprResult BuildConvertedConstantExpression(Sema
&S, Expr *From,
/*InOverloadResolution=*/false,
/*AllowObjCWritebackConversion=*/false,
/*AllowE
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bolshakov-a updated
https://github.com/llvm/llvm-project/pull/71077
>From 02154cf040c55b0d7bd28a3ffbb76c86ca9b878d Mon Sep 17 00:00:00 2001
From: Bolshakov
Date: Thu, 2 Nov 2023 19:20:27 +0300
Subject: [PATCH] [clang] Improve bit-field in ref NTTP diagnostic
Prior to this, a
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll approved this pull request.
LGTM from DR testing perspective.
https://github.com/llvm/llvm-project/pull/71077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -138,7 +138,7 @@ namespace dr1295 { // dr1295: 4
#if __cplusplus <= 201402L
// expected-error@-2 {{does not refer to any declaration}} expected-note@-3
{{here}}
#else
- // expected-error@-4 {{refers to subobject}}
+ // expected-error@-4 {{bind to bit-field in converted
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Andrey Ali Khan Bolshakov (bolshakov-a)
Changes
Prior to this, attempts to bind a bit-field to an NTTP of reference type
produced an error because references to subobjects in NTTPs are disallowed. But
C++20 allows references to subobjects
https://github.com/bolshakov-a created
https://github.com/llvm/llvm-project/pull/71077
Prior to this, attempts to bind a bit-field to an NTTP of reference type
produced an error because references to subobjects in NTTPs are disallowed. But
C++20 allows references to subobjects in NTTPs general
23 matches
Mail list logo
