https://github.com/circl-lastname closed
https://github.com/llvm/llvm-project/pull/117770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3902,6 +3902,8 @@ void Preprocessor::HandleEmbedDirectiveImpl(
}
EmbedAnnotationData *Data = new (BP) EmbedAnnotationData;
+ Data->Filename = Filename;
+ Data->IsAngled = IsAngled;
Data->BinaryData = BinaryContents;
AaronBallman wrote:
I think th
@@ -3902,6 +3902,8 @@ void Preprocessor::HandleEmbedDirectiveImpl(
}
EmbedAnnotationData *Data = new (BP) EmbedAnnotationData;
+ Data->Filename = Filename;
+ Data->IsAngled = IsAngled;
Data->BinaryData = BinaryContents;
circl-lastname wrote:
I'm not
@@ -3902,6 +3902,8 @@ void Preprocessor::HandleEmbedDirectiveImpl(
}
EmbedAnnotationData *Data = new (BP) EmbedAnnotationData;
+ Data->Filename = Filename;
+ Data->IsAngled = IsAngled;
Data->BinaryData = BinaryContents;
Sirraide wrote:
> where can we
@@ -3902,6 +3902,8 @@ void Preprocessor::HandleEmbedDirectiveImpl(
}
EmbedAnnotationData *Data = new (BP) EmbedAnnotationData;
+ Data->Filename = Filename;
+ Data->IsAngled = IsAngled;
Data->BinaryData = BinaryContents;
circl-lastname wrote:
What if
@@ -3902,6 +3902,8 @@ void Preprocessor::HandleEmbedDirectiveImpl(
}
EmbedAnnotationData *Data = new (BP) EmbedAnnotationData;
+ Data->Filename = Filename;
+ Data->IsAngled = IsAngled;
Data->BinaryData = BinaryContents;
circl-lastname wrote:
Similar
circl-lastname wrote:
> We probably want a changelog
I put it in the C23 features section, if that's ok
https://github.com/llvm/llvm-project/pull/117770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/circl-lastname updated
https://github.com/llvm/llvm-project/pull/117770
>From 184359e8be9eab570ef01810d5d3a6ba4a48afe9 Mon Sep 17 00:00:00 2001
From: circl
Date: Tue, 26 Nov 2024 18:52:19 +0100
Subject: [PATCH 1/2] [clang] Store filename in EmbedExpr
---
clang/include/clang
@@ -3902,6 +3902,8 @@ void Preprocessor::HandleEmbedDirectiveImpl(
}
EmbedAnnotationData *Data = new (BP) EmbedAnnotationData;
+ Data->Filename = Filename;
+ Data->IsAngled = IsAngled;
Data->BinaryData = BinaryContents;
Fznamznon wrote:
None that I c
@@ -3902,6 +3902,8 @@ void Preprocessor::HandleEmbedDirectiveImpl(
}
EmbedAnnotationData *Data = new (BP) EmbedAnnotationData;
+ Data->Filename = Filename;
+ Data->IsAngled = IsAngled;
Data->BinaryData = BinaryContents;
circl-lastname wrote:
Is there
@@ -3902,6 +3902,8 @@ void Preprocessor::HandleEmbedDirectiveImpl(
}
EmbedAnnotationData *Data = new (BP) EmbedAnnotationData;
+ Data->Filename = Filename;
+ Data->IsAngled = IsAngled;
Data->BinaryData = BinaryContents;
Fznamznon wrote:
I struggle to
https://github.com/Fznamznon commented:
Thank you for the fix!
I wonder if the new change be tested somehow?
Also, we probably need to update Serialization code with handling for the new
fields of `EmbedExpr`.
https://github.com/llvm/llvm-project/pull/117770
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: circl (circl-lastname)
Changes
Fixes #107869
Due to the other FIXMEs in `#embed` code, this doesn't yet handle offsets,
prefixes, and if_empty, however I feel it's a good start, and preferable to
crashing.
 to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/circl-lastname created
https://github.com/llvm/llvm-project/pull/117770
Fixes #107869
Due to the other FIXMEs in `#embed` code, this doesn't yet handle offsets,
prefixes, and if_empty, however I feel it's a good start, and preferable to
crashing.
