https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/135957
>From b194133f44768a61a7af6486dc40deae2de73f9a Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Wed, 16 Apr 2025 05:59:24 -0700
Subject: [PATCH 1/6] [clang] Implement StmtPrinter for EmbedExpr
Tr
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -435,6 +435,7 @@ ExprResult Parser::createEmbedExpr() {
ExprResult Res;
ASTContext &Context = Actions.getASTContext();
SourceLocation StartLoc = ConsumeAnnotationToken();
+
Fznamznon wrote:
```suggestion
```
https://github.com/llvm/llvm-project/pull/
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/135957
>From b194133f44768a61a7af6486dc40deae2de73f9a Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Wed, 16 Apr 2025 05:59:24 -0700
Subject: [PATCH 1/6] [clang] Implement StmtPrinter for EmbedExpr
Tr
https://github.com/AaronBallman approved this pull request.
LGTM! Precommit CI failures appear to be unrelated.
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
circl-lastname wrote:
LGTM
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/135957
>From b194133f44768a61a7af6486dc40deae2de73f9a Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Wed, 16 Apr 2025 05:59:24 -0700
Subject: [PATCH 1/2] [clang] Implement StmtPrinter for EmbedExpr
Tr
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4049,5 +4050,13 @@ void Preprocessor::HandleEmbedDirective(SourceLocation
HashLoc, Token &EmbedTok,
if (Callbacks)
Callbacks->EmbedDirective(HashLoc, Filename, isAngled, MaybeFileRef,
*Params);
- HandleEmbedDirectiveImpl(HashLoc, *Param
@@ -1284,7 +1284,11 @@ void StmtPrinter::VisitSourceLocExpr(SourceLocExpr
*Node) {
}
void StmtPrinter::VisitEmbedExpr(EmbedExpr *Node) {
- llvm::report_fatal_error("Not implemented");
+ // Embed parameters are not reflected in the AST, so there is no way to print
--
@@ -4049,5 +4050,13 @@ void Preprocessor::HandleEmbedDirective(SourceLocation
HashLoc, Token &EmbedTok,
if (Callbacks)
Callbacks->EmbedDirective(HashLoc, Filename, isAngled, MaybeFileRef,
*Params);
- HandleEmbedDirectiveImpl(HashLoc, *Param
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
Can fix up the formatting issues found by precommit CI, and the change should
also come with a release note.
https://github.com/llvm/llvm-project/pull/135957
___
cfe-commits mailing list
cfe-commits@lists.llv
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
clang/include/clang/AST/Expr.h clang/include/clang/
Fznamznon wrote:
This might also fix https://github.com/llvm/llvm-project/issues/107869 since a
similar fix was proposed earlier to fix it. I don't have any experience with
clangd to verify though.
https://github.com/llvm/llvm-project/pull/135957
__
@@ -136,3 +136,43 @@ constexpr struct HasChar c = {
c-error {{constexpr initializer evaluates to
255 which is not exactly representable in type 'signed char'}}
};
+
+#if __cplusplus
+namespace std {
+typedef decltype(sizeof(int)) size_t;
+
+tem
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mariya Podchishchaeva (Fznamznon)
Changes
Tries to avoid memory leaks caused by saving filename earlier by allocating
memory in the preprocessor.
Fixes https://github.com/llvm/llvm-project/issues/132641
---
Full diff: https://github.com/
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/135957
Tries to avoid memory leaks caused by saving filename earlier by allocating
memory in the preprocessor.
Fixes https://github.com/llvm/llvm-project/issues/132641
>From b194133f44768a61a7af6486dc40deae2de73f9a
19 matches
Mail list logo
