github-actions[bot] wrote:
@bradenhelmer Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a b
https://github.com/zmodem closed https://github.com/llvm/llvm-project/pull/94827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bradenhelmer wrote:
> Do you have access to press the "Squash and merge" button, or should I do it?
You'll have to, i dont have access yet, thx
https://github.com/llvm/llvm-project/pull/94827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
zmodem wrote:
Do you have access to press the "Squash and merge" button, or should I do it?
https://github.com/llvm/llvm-project/pull/94827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/zmodem approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/94827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bradenhelmer updated
https://github.com/llvm/llvm-project/pull/94827
>From 317e4c2fe7fb0ee76f7917b64ee447ba3ed838bc Mon Sep 17 00:00:00 2001
From: Braden Helmer
Date: Fri, 7 Jun 2024 21:38:04 -0400
Subject: [PATCH 1/4] Implement -Wmissing-include-dirs
---
clang/include/clan
https://github.com/bradenhelmer updated
https://github.com/llvm/llvm-project/pull/94827
>From 317e4c2fe7fb0ee76f7917b64ee447ba3ed838bc Mon Sep 17 00:00:00 2001
From: Braden Helmer
Date: Fri, 7 Jun 2024 21:38:04 -0400
Subject: [PATCH 1/3] Implement -Wmissing-include-dirs
---
clang/include/clan
@@ -6,3 +6,7 @@
// Check that -isysroot warns on nonexistent paths.
// RUN: %clang -### -c -target i386-apple-darwin10 -isysroot
%t/warning-options %s 2>&1 | FileCheck --check-prefix=CHECK-ISYSROOT %s
// CHECK-ISYSROOT: warning: no such sysroot directory: '{{.*}}/warning-optio
https://github.com/zmodem commented:
This basically looks good to me. Just a few nits.
https://github.com/llvm/llvm-project/pull/94827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zmodem edited https://github.com/llvm/llvm-project/pull/94827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -809,4 +809,7 @@ def warn_android_unversioned_fallback : Warning<
def err_drv_triple_version_invalid : Error<
"version '%0' in target triple '%1' is invalid">;
+
+def warn_missing_include_dirs : Warning<
+ "the included directory %0 is missing">, InGroup,
DefaultIgnore;
@@ -809,4 +809,7 @@ def warn_android_unversioned_fallback : Warning<
def err_drv_triple_version_invalid : Error<
"version '%0' in target triple '%1' is invalid">;
+
+def warn_missing_include_dirs : Warning <
bradenhelmer wrote:
Tested with GCC, its not enab
https://github.com/bradenhelmer updated
https://github.com/llvm/llvm-project/pull/94827
>From 317e4c2fe7fb0ee76f7917b64ee447ba3ed838bc Mon Sep 17 00:00:00 2001
From: Braden Helmer
Date: Fri, 7 Jun 2024 21:38:04 -0400
Subject: [PATCH 1/2] Implement -Wmissing-include-dirs
---
clang/include/clan
@@ -1271,6 +1271,12 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) {
if (VFS->setCurrentWorkingDirectory(WD->getValue()))
Diag(diag::err_drv_unable_to_set_working_directory) << WD->getValue();
+ // Check for missing include directories
+ for (auto Inclu
https://github.com/zmodem commented:
Thanks! The main missing thing is a test for this. Have a look in
`clang/test/Driver/` to see what the tests can look like.
---
Some existing tests are failing, see
https://buildkite.com/llvm-project/github-pull-requests/builds/70953#018ff782-9ba1-426b-bb3
https://github.com/zmodem edited https://github.com/llvm/llvm-project/pull/94827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1271,6 +1271,12 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) {
if (VFS->setCurrentWorkingDirectory(WD->getValue()))
Diag(diag::err_drv_unable_to_set_working_directory) << WD->getValue();
+ // Check for missing include directories
z
@@ -809,4 +809,7 @@ def warn_android_unversioned_fallback : Warning<
def err_drv_triple_version_invalid : Error<
"version '%0' in target triple '%1' is invalid">;
+
+def warn_missing_include_dirs : Warning <
zmodem wrote:
nit: no space between `Warning` and
https://github.com/bradenhelmer updated
https://github.com/llvm/llvm-project/pull/94827
>From 317e4c2fe7fb0ee76f7917b64ee447ba3ed838bc Mon Sep 17 00:00:00 2001
From: Braden Helmer
Date: Fri, 7 Jun 2024 21:38:04 -0400
Subject: [PATCH] Implement -Wmissing-include-dirs
---
clang/include/clang/Ba
https://github.com/bradenhelmer edited
https://github.com/llvm/llvm-project/pull/94827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Braden Helmer (bradenhelmer)
Changes
Implements -Wmissing-include-dirs #92015
This is my first contribution and would love some feedback. Thanks
---
Full diff: https://github.com/llvm/llvm-project/pull/94827.diff
3 Files Affecte
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Braden Helmer (bradenhelmer)
Changes
Implements -Wmissing-include-dirs #92015
This is my first contribution and would love some feedback. Thanks
---
Full diff: https://github.com/llvm/llvm-project/pull/94827.diff
3 Files Affected:
- (
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/bradenhelmer created
https://github.com/llvm/llvm-project/pull/94827
Implements -Wmissing-include-dirs #92015
This is my first contribution and would love some feedback. Thanks
>From 317e4c2fe7fb0ee76f7917b64ee447ba3ed838bc Mon Sep 17 00:00:00 2001
From: Braden Helmer
Date
24 matches
Mail list logo
