Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
https://
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =
alejandro-alvarez-sonarsource wrote:
> Do you need someone to commit these changes for you? (If so, I can apply the
> changes myself and land them.)
Yes, please, I can't merge myself.
https://github.com/llvm/llvm-project/pull/109147
___
cfe-commits m
@@ -141,10 +143,11 @@ struct PrintingPolicy {
unsigned SuppressUnwrittenScope : 1;
/// Suppress printing parts of scope specifiers that correspond
- /// to inline namespaces, where the name is unambiguous with the specifier
+ /// to inline namespaces.
+ /// If Redudant,
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/109147
From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Mon, 24 Jul 2023 13:56:29 +0200
Subject: [PATCH 1/8] [
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/109147
From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Mon, 24 Jul 2023 13:56:29 +0200
Subject: [PATCH 1/7] [
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=
Message-ID:
In-Reply-To:
@@ -141,10 +143
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
@@ -1737,9 +1737,17 @@ void NamedDecl::printNestedNameSpecifier(raw
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
@@ -636,6 +636,9 @@ AST Matchers
- Fixed a crash when traverse l
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
https://github.com/AaronBallman approved this pull request.
LGTM with some minor co
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/10
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/109147
From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Mon, 24 Jul 2023 13:56:29 +0200
Subject: [PATCH 1/6] [
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/109147
From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Mon, 24 Jul 2023 13:56:29 +0200
Subject: [PATCH 1/5] [
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/109147
From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Mon, 24 Jul 2023 13:56:29 +0200
Subject: [PATCH 1/4] [
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-
alejandro-alvarez-sonarsource wrote:
> > Or even SuppressInlineNamespace should be changed from bool to some enum
> > like None, Redundant, All.
>
> I think this is the suggestion I'd prefer; it's cleaner than adding a second
> boolean option.
Agreed. And changes.
> Make sure that all curre
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/109147
From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Mon, 24 Jul 2023 13:56:29 +0200
Subject: [PATCH 1/3] [
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/109147
From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Mon, 24 Jul 2023 13:56:29 +0200
Subject: [PATCH 1/3] [
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/109147
From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Mon, 24 Jul 2023 13:56:29 +0200
Subject: [PATCH 1/2] [
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
https://github.com/PiotrZSL commented:
Code looks fine.
Only thing is that existence of SuppressInlineNamespace and
AlwaysSuppressInlineNamespace looks redundant.
Probably one should be named SuppressRedundantInlineNamespace and othe
alejandro-alvarez-sonarsource wrote:
Ping (@PiotrZSL ?)
https://github.com/llvm/llvm-project/pull/109147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alejandro-alvarez-sonarsource wrote:
> Also, it needs a release note I think for the matcher change.
Added.
> I have no problem with the code here, but don't know enough about ASTMatchers
> to be able to review this for 'well justified'. Do we have someone besides
> Aaron who does?
FWIW this
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/109147
From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Mon, 24 Jul 2023 13:56:29 +0200
Subject: [PATCH 1/2] [
Sirraide wrote:
I can’t help w/ AST matchers either unfortunately.
https://github.com/llvm/llvm-project/pull/109147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
I have no problem with the code here, but don't know enough about ASTMatchers
to be able to review this for 'well justified'. Do we have someone besides
Aaron who does?
Also, it needs a release note I think for the matcher change.
https://github.com/ll
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Alejandro Álvarez Ayllón (alejandro-alvarez-sonarsource)
Changes
Add a new flag `AlwaysSuppressInlineNamespace` to `PrintingPolicy` that is
explicit
about *always* removing inline namespaces regardless of ambiguity.
Specializing a templat
https://github.com/alejandro-alvarez-sonarsource created
https://github.com/llvm/llvm-project/pull/109147
Add a new flag `AlwaysSuppressInlineNamespace` to `PrintingPolicy` that is
explicit
about *always* removing inline namespaces regardless of ambiguity.
Specializing a template from an inlin
27 matches
Mail list logo
