efriedma-quic wrote:
The failure is essentially a bootstrap failure. (The buildbot in question is
not technically bootstrapping, but it's using clang 18 as the host compiler.)
https://github.com/llvm/llvm-project/pull/100724
___
cfe-commits mailing l
cor3ntin wrote:
@efriedma-quic this is about clang missing a symbol, not generated code
https://github.com/llvm/llvm-project/pull/100724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
The mangler is in clang/lib/AST/ItaniumMangle.cpp; maybe look at
CXXNameMangler::mangleStandardSubstitution.
https://github.com/llvm/llvm-project/pull/100724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
rorth wrote:
FWIW, the hack even breaks when doing a `Debug` build: in that case the
unresolved reference returns despite the hack.
https://github.com/llvm/llvm-project/pull/100724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/100724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rorth wrote:
Right, as is it's just a ugly hack with the underlying problem like to rear its
ugly head again in the future.
https://github.com/llvm/llvm-project/pull/100724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
AaronBallman wrote:
> > > Whatever the case, we need at least a short-term solution now: the
> > > Solaris buildbots have been broken for two days now.
> >
> >
> > Agreed that we need something in the short term, I'm just trying to find
> > the cleanest "something" under the assumption that t
https://github.com/AaronBallman approved this pull request.
LGTM; if we find a better approach post-commit, this is easy enough to remove.
Thanks!
https://github.com/llvm/llvm-project/pull/100724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rorth wrote:
> > Whatever the case, we need at least a short-term solution now: the Solaris
> > buildbots have been broken for two days now.
>
> Agreed that we need something in the short term, I'm just trying to find the
> cleanest "something" under the assumption that this hack will live for
AaronBallman wrote:
> Whatever the case, we need at least a short-term solution now: the Solaris
> buildbots have been broken for two days now.
Agreed that we need something in the short term, I'm just trying to find the
cleanest "something" under the assumption that this hack will live for a
rorth wrote:
> Thank you for helping out with this odd edge case! I don't suppose there's a
> way we can shove this hack into CMake (basically, like a kind of linker
> script hack)? If so, can we apply it broadly enough so that any use of
> `time_put` in other TUs will also benefit?
This woul
https://github.com/AaronBallman commented:
Thank you for helping out with this odd edge case! I don't suppose there's a
way we can shove this hack into CMake (basically, like a kind of linker script
hack)? If so, can we apply it broadly enough so that any use of `time_put` in
other TUs will al
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rainer Orth (rorth)
Changes
The introduction of `std::put_time` in
fad17b43dbc09ac7e0a95535459845f72c2b739a broke the Solaris build:
```
Undefined first referenced
symbol in file
_ZNKSt8tim
https://github.com/rorth created
https://github.com/llvm/llvm-project/pull/100724
The introduction of `std::put_time` in
fad17b43dbc09ac7e0a95535459845f72c2b739a broke the Solaris build:
```
Undefined first referenced
symbol in file
_ZNKSt8time_
14 matches
Mail list logo